Andrew Smith#259
Open
continentaldivide wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deliverable Submission
Please describe your comfort and completeness levels before submitting.
Comfort Level (1-5): 3
Completeness Level (1-5): 4.5 (didn't style but implemented all MVP functionality)
What did you think of this deliverable?: this one was hard. I think the suggestions/hints in part 3, bullet point 2 are not as clear as they could be (I spent a long time stuck here trying to make sense of which tools to use to put the pieces together in the right order) -- further, user story "as a user, I want to assign multiple categories to a single project" insinuates that this is part of MVP for the assignment but no steps before bonus reference this objective or allude to designing with the necessary functionality in mind. Unclear whether it's an expectation for MVP or not.
(cool project tho, I ain't complainin')