New Horizontal_grid_cell : tempgrid_matsbn-1783965316#1069
Open
github-actions[bot] wants to merge 1 commit into
Open
New Horizontal_grid_cell : tempgrid_matsbn-1783965316#1069github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Contributor
Author
|
Note This report has three parts: Legend —
1. Field Status8 submitted · ✅ 2 validated · 👀 6 need manual review
2. Controlled Vocabulary LinksChecking that linked files resolve: 3/4 (75%) Graph of links in submission.graph TD
tempgrid_matsbn_1783965316(["tempgrid_matsbn-1783965316"])
subgraph sg_grid_mapping["grid_mapping"]
grid_mapping_polar_stereographic["polar-stereographic"]
click grid_mapping_polar_stereographic "https://constants.mipcvs.dev/grid_mapping/polar-stereographic.json" _blank
end
tempgrid_matsbn_1783965316 --> grid_mapping_polar_stereographic
subgraph sg_grid_type["grid_type"]
grid_type_plane_projection["plane-projection"]
click grid_type_plane_projection "https://constants.mipcvs.dev/grid_type/plane-projection.json" _blank
end
tempgrid_matsbn_1783965316 --> grid_type_plane_projection
subgraph sg_temporal_refinement["temporal_refinement"]
temporal_refinement_static["static"]
click temporal_refinement_static "https://constants.mipcvs.dev/temporal_refinement/static.json" _blank
end
tempgrid_matsbn_1783965316 --> temporal_refinement_static
Warning 5 existing item(s) share ≥85% link overlap. Review field differences below before merging.
g185 `██████████` — Links: 3/3 (100.0% | 70.2%)
g191 `██████████` — Links: 3/3 (100.0% | 49.6%)
g194 `██████████` — Links: 3/3 (100.0% | 53.9%)
g192 `██████████` — Links: 3/3 (100.0% | 52.5%)
g193 `██████████` — Links: 3/3 (100.0% | 51.7%)
All CV link comparisonsg185 `██████████` — Links: 3/3 (100.0% | 70.2%)
g191 `██████████` — Links: 3/3 (100.0% | 49.6%)
g194 `██████████` — Links: 3/3 (100.0% | 53.9%)
g192 `██████████` — Links: 3/3 (100.0% | 52.5%)
g193 `██████████` — Links: 3/3 (100.0% | 51.7%)
g199 `██████░░░░` — Links: 2/3 (66.7% | 79.8%)
g184 `███░░░░░░░` — Links: 1/3 (33.3% | 53.4%)
g156 `███░░░░░░░` — Links: 1/3 (33.3% | 51.1%)
g155 `███░░░░░░░` — Links: 1/3 (33.3% | 51.6%)
g120 `███░░░░░░░` — Links: 1/3 (33.3% | 68.8%)
g189 `███░░░░░░░` — Links: 1/3 (33.3% | 47.3%)
g180 `███░░░░░░░` — Links: 1/3 (33.3% | 45.8%)
g181 `███░░░░░░░` — Links: 1/3 (33.3% | 55.0%)
g127 `███░░░░░░░` — Links: 1/3 (33.3% | 51.0%)
g110 `███░░░░░░░` — Links: 1/3 (33.3% | 49.3%)
g131 `███░░░░░░░` — Links: 1/3 (33.3% | 56.2%)
g126 `███░░░░░░░` — Links: 1/3 (33.3% | 46.2%)
g170 `███░░░░░░░` — Links: 1/3 (33.3% | 49.9%)
g100 `███░░░░░░░` — Links: 1/3 (33.3% | 57.0%)
g141 `███░░░░░░░` — Links: 1/3 (33.3% | 47.7%)
g197 `███░░░░░░░` — Links: 1/3 (33.3% | 52.5%)
g111 `███░░░░░░░` — Links: 1/3 (33.3% | 53.8%)
g103 `███░░░░░░░` — Links: 1/3 (33.3% | 50.8%)
g119 `███░░░░░░░` — Links: 1/3 (33.3% | 48.7%)
g167 `███░░░░░░░` — Links: 1/3 (33.3% | 53.5%)
g168 `███░░░░░░░` — Links: 1/3 (33.3% | 50.7%)
g187 `███░░░░░░░` — Links: 1/3 (33.3% | 51.1%)
g190 `███░░░░░░░` — Links: 1/3 (33.3% | 75.1%)
g154 `███░░░░░░░` — Links: 1/3 (33.3% | 52.7%)
g137 `███░░░░░░░` — Links: 1/3 (33.3% | 52.2%)
g176 `███░░░░░░░` — Links: 1/3 (33.3% | 60.7%)
g145 `███░░░░░░░` — Links: 1/3 (33.3% | 50.4%)
g201 `███░░░░░░░` — Links: 1/3 (33.3% | 50.4%)
g150 `███░░░░░░░` — Links: 1/3 (33.3% | 54.4%)
g140 `███░░░░░░░` — Links: 1/3 (33.3% | 50.9%)
g151 `███░░░░░░░` — Links: 1/3 (33.3% | 51.1%)
g159 `███░░░░░░░` — Links: 1/3 (33.3% | 53.8%)
g117 `███░░░░░░░` — Links: 1/3 (33.3% | 52.9%)
g143 `███░░░░░░░` — Links: 1/3 (33.3% | 84.5%)
g104 `███░░░░░░░` — Links: 1/3 (33.3% | 50.6%)
g128 `███░░░░░░░` — Links: 1/3 (33.3% | 51.7%)
g164 `███░░░░░░░` — Links: 1/3 (33.3% | 72.9%)
g116 `███░░░░░░░` — Links: 1/3 (33.3% | 79.8%)
g198 `███░░░░░░░` — Links: 1/3 (33.3% | 52.8%)
g160 `███░░░░░░░` — Links: 1/3 (33.3% | 52.8%)
g142 `███░░░░░░░` — Links: 1/3 (33.3% | 49.4%)
g174 `███░░░░░░░` — Links: 1/3 (33.3% | 55.0%)
g178 `███░░░░░░░` — Links: 1/3 (33.3% | 58.4%)
g186 `███░░░░░░░` — Links: 1/3 (33.3% | 50.7%)
g138 `███░░░░░░░` — Links: 1/3 (33.3% | 49.8%)
g195 `███░░░░░░░` — Links: 1/3 (33.3% | 77.6%)
g148 `███░░░░░░░` — Links: 1/3 (33.3% | 49.2%)
g149 `███░░░░░░░` — Links: 1/3 (33.3% | 49.5%)
g163 `███░░░░░░░` — Links: 1/3 (33.3% | 52.9%)
g122 `███░░░░░░░` — Links: 1/3 (33.3% | 48.0%)
g114 `███░░░░░░░` — Links: 1/3 (33.3% | 56.4%)
g169 `███░░░░░░░` — Links: 1/3 (33.3% | 48.7%)
g171 `███░░░░░░░` — Links: 1/3 (33.3% | 50.3%)
g108 `███░░░░░░░` — Links: 1/3 (33.3% | 52.1%)
g153 `███░░░░░░░` — Links: 1/3 (33.3% | 53.1%)
g157 `███░░░░░░░` — Links: 1/3 (33.3% | 49.6%)
g121 `███░░░░░░░` — Links: 1/3 (33.3% | 55.3%)
g146 `███░░░░░░░` — Links: 1/3 (33.3% | 52.3%)
g124 `███░░░░░░░` — Links: 1/3 (33.3% | 47.2%)
g177 `███░░░░░░░` — Links: 1/3 (33.3% | 62.2%)
g152 `███░░░░░░░` — Links: 1/3 (33.3% | 55.8%)
g139 `███░░░░░░░` — Links: 1/3 (33.3% | 51.8%)
g115 `███░░░░░░░` — Links: 1/3 (33.3% | 53.1%)
g123 `███░░░░░░░` — Links: 1/3 (33.3% | 52.4%)
g106 `███░░░░░░░` — Links: 1/3 (33.3% | 53.7%)
g162 `███░░░░░░░` — Links: 1/3 (33.3% | 51.4%)
g129 `███░░░░░░░` — Links: 1/3 (33.3% | 48.8%)
g175 `███░░░░░░░` — Links: 1/3 (33.3% | 54.1%)
g158 `███░░░░░░░` — Links: 1/3 (33.3% | 56.4%)
g196 `███░░░░░░░` — Links: 1/3 (33.3% | 51.2%)
g132 `███░░░░░░░` — Links: 1/3 (33.3% | 70.9%)
g166 `███░░░░░░░` — Links: 1/3 (33.3% | 70.6%)
g113 `███░░░░░░░` — Links: 1/3 (33.3% | 51.5%)
g112 `███░░░░░░░` — Links: 1/3 (33.3% | 50.1%)
g165 `███░░░░░░░` — Links: 1/3 (33.3% | 71.3%)
g130 `███░░░░░░░` — Links: 1/3 (33.3% | 69.5%)
g125 `███░░░░░░░` — Links: 1/3 (33.3% | 49.6%)
g136 `███░░░░░░░` — Links: 1/3 (33.3% | 49.0%)
g105 `███░░░░░░░` — Links: 1/3 (33.3% | 49.3%)
g134 `███░░░░░░░` — Links: 1/3 (33.3% | 51.2%)
g118 `███░░░░░░░` — Links: 1/3 (33.3% | 79.9%)
g200 `███░░░░░░░` — Links: 1/3 (33.3% | 50.1%)
g101 `███░░░░░░░` — Links: 1/3 (33.3% | 49.0%)
g183 `███░░░░░░░` — Links: 1/3 (33.3% | 47.2%)
g179 `███░░░░░░░` — Links: 1/3 (33.3% | 54.0%)
g102 `███░░░░░░░` — Links: 1/3 (33.3% | 51.7%)
g133 `███░░░░░░░` — Links: 1/3 (33.3% | 55.5%)
g172 `███░░░░░░░` — Links: 1/3 (33.3% | 52.1%)
g161 `███░░░░░░░` — Links: 1/3 (33.3% | 72.5%)
g109 `███░░░░░░░` — Links: 1/3 (33.3% | 50.1%)
g188 `███░░░░░░░` — Links: 1/3 (33.3% | 51.0%)
g107 `███░░░░░░░` — Links: 1/3 (33.3% | 52.0%)
g144 `███░░░░░░░` — Links: 1/3 (33.3% | 51.0%)
g173 `███░░░░░░░` — Links: 1/3 (33.3% | 52.9%)
g135 `███░░░░░░░` — Links: 1/3 (33.3% | 47.0%)
g147 `███░░░░░░░` — Links: 1/3 (33.3% | 49.2%)
g182 `███░░░░░░░` — Links: 1/3 (33.3% | 47.8%)
3. Content Similarity5 field(s) compared using embedding. Fields included in comparison
No existing items exceed 85% content similarity. All content comparisonsg143 `████████░░` — 84.5%
g118 `███████░░░` — 79.9%
g199 `███████░░░` — 79.8%
g116 `███████░░░` — 79.8%
g195 `███████░░░` — 77.6%
g190 `███████░░░` — 75.1%
g164 `███████░░░` — 72.9%
g161 `███████░░░` — 72.5%
g165 `███████░░░` — 71.3%
g132 `███████░░░` — 70.9%
g166 `███████░░░` — 70.6%
g185 `███████░░░` — 70.2%
g130 `██████░░░░` — 69.5%
g120 `██████░░░░` — 68.8%
g177 `██████░░░░` — 62.2%
g176 `██████░░░░` — 60.7%
g178 `█████░░░░░` — 58.4%
g100 `█████░░░░░` — 57.0%
g114 `█████░░░░░` — 56.4%
g158 `█████░░░░░` — 56.4%
g131 `█████░░░░░` — 56.2%
g152 `█████░░░░░` — 55.8%
g133 `█████░░░░░` — 55.5%
g121 `█████░░░░░` — 55.3%
g181 `█████░░░░░` — 55.0%
g174 `█████░░░░░` — 55.0%
g150 `█████░░░░░` — 54.4%
g175 `█████░░░░░` — 54.1%
g179 `█████░░░░░` — 54.0%
g194 `█████░░░░░` — 53.9%
g111 `█████░░░░░` — 53.8%
g159 `█████░░░░░` — 53.8%
g106 `█████░░░░░` — 53.7%
g167 `█████░░░░░` — 53.5%
g184 `█████░░░░░` — 53.4%
g153 `█████░░░░░` — 53.1%
g115 `█████░░░░░` — 53.1%
g117 `█████░░░░░` — 52.9%
g163 `█████░░░░░` — 52.9%
g173 `█████░░░░░` — 52.9%
g198 `█████░░░░░` — 52.8%
g160 `█████░░░░░` — 52.8%
g154 `█████░░░░░` — 52.7%
g197 `█████░░░░░` — 52.5%
g192 `█████░░░░░` — 52.5%
g123 `█████░░░░░` — 52.4%
g146 `█████░░░░░` — 52.3%
g137 `█████░░░░░` — 52.2%
g108 `█████░░░░░` — 52.1%
g172 `█████░░░░░` — 52.1%
g107 `█████░░░░░` — 52.0%
g139 `█████░░░░░` — 51.8%
g128 `█████░░░░░` — 51.7%
g193 `█████░░░░░` — 51.7%
g102 `█████░░░░░` — 51.7%
g155 `█████░░░░░` — 51.6%
g113 `█████░░░░░` — 51.5%
g162 `█████░░░░░` — 51.4%
g196 `█████░░░░░` — 51.2%
g134 `█████░░░░░` — 51.2%
g156 `█████░░░░░` — 51.1%
g187 `█████░░░░░` — 51.1%
g151 `█████░░░░░` — 51.1%
g127 `█████░░░░░` — 51.0%
g188 `█████░░░░░` — 51.0%
g144 `█████░░░░░` — 51.0%
g140 `█████░░░░░` — 50.9%
g103 `█████░░░░░` — 50.8%
g168 `█████░░░░░` — 50.7%
g186 `█████░░░░░` — 50.7%
g104 `█████░░░░░` — 50.6%
g145 `█████░░░░░` — 50.4%
g201 `█████░░░░░` — 50.4%
g171 `█████░░░░░` — 50.3%
g112 `█████░░░░░` — 50.1%
g200 `█████░░░░░` — 50.1%
g109 `█████░░░░░` — 50.1%
g170 `████░░░░░░` — 49.9%
g138 `████░░░░░░` — 49.8%
g191 `████░░░░░░` — 49.6%
g157 `████░░░░░░` — 49.6%
g125 `████░░░░░░` — 49.6%
g149 `████░░░░░░` — 49.5%
g142 `████░░░░░░` — 49.4%
g110 `████░░░░░░` — 49.3%
g105 `████░░░░░░` — 49.3%
g148 `████░░░░░░` — 49.2%
g147 `████░░░░░░` — 49.2%
g136 `████░░░░░░` — 49.0%
g101 `████░░░░░░` — 49.0%
g129 `████░░░░░░` — 48.8%
g119 `████░░░░░░` — 48.7%
g169 `████░░░░░░` — 48.7%
g122 `████░░░░░░` — 48.0%
g182 `████░░░░░░` — 47.8%
g141 `████░░░░░░` — 47.7%
g189 `████░░░░░░` — 47.3%
g124 `████░░░░░░` — 47.2%
g183 `████░░░░░░` — 47.2%
g135 `████░░░░░░` — 47.0%
g126 `████░░░░░░` — 46.2%
g180 `████░░░░░░` — 45.8%
Generated by cmipld · 2026-07-13 17:57 UTC from Issue 1067 Last updated: 2026-07-13 17:57 UTC |
Darwyn72
approved these changes
Jul 17, 2026
Darwyn72
left a comment
Darwyn72
left a comment
Collaborator
There was a problem hiding this comment.
OK to merge but question for @davidhassell @wolfiex @crgoddard the automatic warnings under Controlled Vocabulary links are correct - the content is 100% identical to existing - so what happens in these cases?
Contributor
There was a problem hiding this comment.
Pull request overview
EMD Copilot Review:
This is an automated review. It is used to aid the reviewer in identifying areas to check, but should not be used on its own.
Concerns
Note
[Grid] units / x_resolution / y_resolution: These are blank, but the description states two isotropic resolutions (4 km for Greenland, 8 km for Antarctica). If this is intended to be a single mosaic grid, consider how those resolutions should be represented in the structured fields; otherwise consider splitting into separate grid-cell entries.
Errors
Caution
[Grid] region: region is given as a single string "greenland, antarctica", which does not match the allowed CV terms (greenland, antarctica, etc.; see .github/emd-review-ref.json horizontal_grid_cell.region_cv). This is likely to fail validation unless represented as separate CV values (or replaced with a single appropriate CV term such as limited_area, if that is the intent).
A new horizontal_grid_cell JSON-LD entry is being added to document a polar-stereographic plane-projection grid covering Greenland and Antarctica, as requested in issue #1067.
Changes:
- Added
horizontal_grid_cell/tempgrid_matsbn-1783965316.jsondescribing a Greenland+Antarctica plane-projection grid cell. - Captured cell count and bounding metadata (southernmost latitude, westernmost longitude) and a free-text description of subregion characteristics.
Comment on lines
+9
to
+11
| "region": [ | ||
| "greenland, antarctica" | ||
| ], |
Comment on lines
+16
to
+19
| "units": "", | ||
| "westernmost_longitude": 0, | ||
| "x_resolution": "", | ||
| "y_resolution": "", |
Collaborator
|
See comment on #1070 |
crgoddard
added
reviewer-comment
Contributor
@crgoddard, see follow up comment #1070 (comment). |
Collaborator
|
@matsbn that does make sense now, I forgot about the discussion. So, I think this is ready to merge, but I'll still leave it to @davidhassell to have the final say. |
crgoddard
added
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1067
Submitted data
{ "validation_key": "tempgrid_matsbn-1783965316", "ui_label": "Horizontal grid cell with a plane projection grid type.", "description": "Grid cell for Greenland and Antarctic subregions. The Greenland region has 303541 grid cells, isotropic resolution of 4 km, southernmost latitude of 57.784° and westernmost longitude of 330.550°. The Antarctic region has 579121 grid cells and isotropic resolution of 8 km.", "alias": [], "grid_mapping": "polar-stereographic", "grid_type": "plane-projection", "n_cells": 882662, "region": [ "greenland, antarctica" ], "southernmost_latitude": -90, "temporal_refinement": "static", "truncation_method": "", "truncation_number": "", "units": "", "westernmost_longitude": 0, "x_resolution": "", "y_resolution": "", "@context": "_context", "@type": [ "emd", "wcrp:horizontal_grid_cell", "esgvoc:HorizontalGridCell" ], "@id": "tempgrid_matsbn-1783965316" }A full review report is posted as a comment below.
Last updated: 2026-07-13 17:57 UTC
Submitter: @matsbn