Fix ClassDAreTeammates config being ignored for Class-D friendly fire - #12
Open
dualfroz wants to merge 1 commit into
Open
Fix ClassDAreTeammates config being ignored for Class-D friendly fire#12dualfroz wants to merge 1 commit into
dualfroz wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Repo: Vretu-Dev/UsefulHints
Base: main
Head: dualfroz:fix/classd-teammates-friendly-fire
No tracking issue (behaviour bug found while reading the source; nothing to
Closes).The
ClassDAreTeammatesoption currently has no effect. InFFWarning.OnHurtingthe
ifbranch that gated the warning onConfig.ClassDAreTeammatesand itselsebranch were identical:
Both paths showed the warning, so setting
ClassDAreTeammates: falsestill fired thefriendly-fire warning when one Class-D hurt another.
This collapses the duplicated branches into a single guarded block, so the warning is
skipped only for the intended case: two Class-D players hurting each other while
ClassDAreTeammatesisfalse. Every other same-side pairing (MTF, Chaos, etc.) isunchanged.
Root cause:
UsefulHints/EventHandlers/Modules/FFWarning.cs, lines 28-38 (parentcommit 3c4e6b0), inside
FFWarning.OnHurting.Flags
SECURITY.md found in this repository; README.md has no AI-disclosure or
CLA/DCO language either. No policy gate applies.
pulls?state=open&per_page=100and all issues, all-time, onVretu-Dev/UsefulHints).Limitations
only the isolated boolean-logic extraction was run.