Merge upstream/main into fork — v1.4.0+ resync (117 commits)

.claude/skills/gascity-docs/SKILL.md

@@ -186,8 +186,9 @@ freshness test (`TestCLIDocsFreshness`) fails if they drift.
 Run the gates in [references/verification.md](references/verification.md). The
 durable repo gates are **`make check-docs`** (nav↔file + local markdown links),
 **`make diagrams-excalidraw`** (if you touched diagrams), `go run ./cmd/genschema`
-(if you touched generated docs), and **`make dashboard-check`** (if you touched
-`internal/api/`, the OpenAPI spec, or the dashboard). Beyond the gates: every TOML
+(if you touched generated docs), and **`make dashboard-ci`** (if you touched
+`internal/api/`, the OpenAPI spec, or the dashboard — `dashboard-check` alone
+does not catch a stale generated client). Beyond the gates: every TOML
 fence must parse, every internal link and anchor must resolve, no page is orphaned
 from the nav, and no body H1 was introduced. Preview on the live site with `make
 docs-dev` (or `./mint.sh dev`) at `localhost:3000`.

.claude/skills/gascity-docs/references/verification.md

@@ -17,8 +17,11 @@ make diagrams-excalidraw
 go run ./cmd/genschema     # writes docs/reference/{cli.md,config.md,schema/*}
 
 # 4. API / dashboard: required when you touch internal/api/, the OpenAPI spec,
-#    docs/reference/schema/openapi.*, or the dashboard.
-make dashboard-check
+#    docs/reference/schema/openapi.*, or the dashboard. dashboard-check alone
+#    typechecks/builds/tests against whatever client is already on disk — it
+#    does not regenerate it, so it misses a client that's drifted from the
+#    spec. dashboard-ci adds that regen + fail-on-drift check.
+make dashboard-ci
 
 # 5. Live preview while editing.
 make docs-dev              # or: ./mint.sh dev   -> http://localhost:3000

.githooks/pre-commit

@@ -45,17 +45,21 @@ if [ -n "$staged_docs" ]; then
   make check-docs
 fi
 
+# Re-read the index rather than reusing the pre-hook staged_spec snapshot:
+# the Go block above runs `go run ./cmd/genspec` and stages the regenerated
+# internal/api/openapi.json, so a Go-only commit that moves the API surface
+# only shows up here (#4627, #4607). Shared by both branches below so the
+# npm-absent fail-closed branch sees the same side effect the npm-present
+# branch already accounts for (ga-jg89a5) -- the branches must not diverge
+# on which snapshot of "is the spec staged" they trust.
+spec_changed=$(git diff --cached --name-only --diff-filter=ACM -- 'internal/api/openapi.json' || true)
+
 # Dashboard SPA rebuild: when internal/api/openapi.json changes, regenerate
 # the generated TS API client from the new spec and stage it. When the spec
 # OR the SPA source changes, typecheck and rebuild the compiled bundle.
 # Guarded on `npm` availability so contributors without Node tooling aren't
 # blocked; CI enforces the full regeneration via make dashboard-ci.
 if command -v npm >/dev/null 2>&1; then
-  # Re-read the index rather than reusing the pre-hook snapshot: the Go
-  # block above runs `go run ./cmd/genspec` and stages the regenerated
-  # internal/api/openapi.json, so a Go-only commit that moves the API
-  # surface only shows up here (#4627, #4607).
-  spec_changed=$(git diff --cached --name-only --diff-filter=ACM -- 'internal/api/openapi.json' || true)
   if [ -n "$spec_changed" ]; then
     # Regenerate BEFORE typecheck/build below: a client that no longer
     # matches the new spec must fail typecheck immediately instead of
@@ -80,5 +84,12 @@ if command -v npm >/dev/null 2>&1; then
     fi
   fi
 else
+  if [ -n "$spec_changed" ]; then
+    echo "error: internal/api/openapi.json is staged but npm is not on PATH — the generated TS API client" >&2
+    echo "cannot be regenerated, so this commit would ship a stale client with no enforcement until CI runs." >&2
+    echo "Install Node/npm, or regenerate manually:" >&2
+    echo "  cd internal/api/dashboardspa/web && npm ci && npm run generate:client" >&2
+    exit 1
+  fi
   echo "warning: npm not on PATH — skipped dashboard SPA typecheck + rebuild. CI will enforce this." >&2
 fi

.github/workflows/ci.yml

@@ -109,6 +109,7 @@ jobs:
               - 'Makefile'
               - 'internal/worker/**'
               - 'internal/sessionlog/**'
+              - 'internal/modelwindow/**'
               - 'internal/runtime/**'
               - 'internal/config/**'
               - 'cmd/gc/template_resolve*.go'
@@ -121,6 +122,7 @@ jobs:
               - 'Makefile'
               - 'internal/worker/**'
               - 'internal/sessionlog/**'
+              - 'internal/modelwindow/**'
               - 'internal/runtime/**'
               - 'internal/config/**'
               - 'cmd/gc/**'