Repository navigation
fix: treat a check range with only a minimum as open above - #79
Open
VolodymyrLinuxovich wants to merge 1 commit into
Open
VolodymyrLinuxovich wants to merge 1 commit into
VolodymyrLinuxovich wants to merge 1 commit into
Conversation
checkSizeScore used the minimum as the maximum when no maximum was set, so "checks over $1M" scored an investor writing $2M to $5M as a mismatch. A minimum alone now leaves the range open above, as a maximum alone already leaves it open below. Fixes #78
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Oct 17, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #78
Summary
checkSizeScorenow leaves a range open above when it has only a minimum. Before it used the minimum as the maximum. So "checks over $1M" scored an investor who writes 2000000 to 5000000 as a mismatch. That investor now scores 100. An investor below the minimum still scores 10. This matches the hard filter in search.ts. It already reads a minimum as a lower bound.Validation