Repository navigation
fix: read people search lead phrases as whole words - #77
Merged
Merged
Conversation
extractAfterPhrases had no word boundary before the phrase, so "using" matched inside "focusing" and "housing". "investors focusing on robotics" gave the technology keyword "on robotics". Fixes #76
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #76
Summary
extractAfterPhrasesin query.ts now starts its pattern with a word boundary. A lead phrase only matches as a whole word. "investors focusing on robotics" no longer giveson roboticsas a technology keyword. "angels backing housing startups" no longer givesstartups. A real phrase like "working on robotics" still givesrobotics.Open PR #69 also edits query.ts on its own branch. It changes other lines, so no conflict is expected.
Validation