Repository navigation
fix: keep non Latin letters when normalizing person names - #67
Merged
Merged
Conversation
normalizedName and the provider dedupe key kept only a to z, so Cyrillic or CJK names became empty and different people at one fund were dropped as duplicates. Names now keep letters from every script and drop accents. Provider organization lookup uses the same key. Fixes #66
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66
Summary
Name normalization now keeps letters from every script. It still lowercases and drops accents, so José and Jose share a key.
Provider dedupe uses this for the person name and the organization name. Two different Cyrillic named investors at one fund are both kept. A true repeat of the same person is still removed.
Provider organization lookup by name uses the same key. Two Cyrillic fund names no longer share an empty key.
Validation