Conversation
|
Тесты бы, конечно, не помешали. Во-первых, можно было бы точно сказать, что вы это хоть как-то запускали (в репозитории не нашла main), во-вторых, я бы видела, в каких случаях вы уверены, что ваш код работает правильно. |
Owner
Author
|
@PanovaElena Я написал кучу, но у меня дурит вывод, возможно это что-то с VS |
PanovaElena
reviewed
Mar 25, 2020
| } | ||
|
|
||
| int leftchild(int _i) { | ||
| return 2 * _i + 1; |
There was a problem hiding this comment.
Лучше бы задефайнить константу d=2, чтобы это все работало для общего случая.
Owner
Author
There was a problem hiding this comment.
Хорошо. А с выводом я разобрался, были какие-то проблемы с загрузкой символов
|
Супер, принято. |
|
А как именно у вас вывод дурит? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@PanovaElena Если нужно, допишу тесты