bring back shlex parser due to shell related difficulties#154
Merged
Vizonex merged 2 commits intoJul 11, 2026
Merged
Conversation
Vizonex
deleted the
153-create_subprocess_shell-on-windows-corrupts-embedded-quotes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Brings back shlex parser -_- (This is not what I wanted originally due to it's own annoyance)
We really don't want to change shitloads of code and I realize that it could affect the merge to uvloop.
This has a been double edge sword of annoyance that I want gone for good.
Are there changes in behavior for the user?
shlex parser had to be returned as much as I hated it we really do not want to do the full formatting of the string which causes the subprocess to just hang in limbo -_-. To avoid this annoyance the shlex module had to make a return.
Is it a substantial burden for the maintainers to support this?
It's worrying me quite a bit but this is at least maintainable but something uvloop after merging winloop will definately need to optimize in the future.
Related issue number
fixes #153
Checklist