Repository navigation
Shrink the icon so the Marketplace accepts releases (4.3.11) - #1234
Merged
ddehilster merged 1 commit intoOct 13, 2026
Merged
Conversation
Every release since 4.3.4 failed at "Publish to the VS Code Marketplace": "The provided icon image exceeds the maximum allowed dimensions of 1024 by 1024 pixels." resources/NLPppLogo.png was 2066 x 2066. 4.3.5 and 4.3.6 hit it with vsce 3.9.2, so it is the Marketplace's limit, not the vsce 4 bump. GitHub releases 4.3.5-4.3.10 exist; the Marketplace still serves 4.3.4. The icon is resized to 1024 x 1024 (Lanczos, RGBA kept), and scripts/check-icon.js reads the PNG header of package.json's icon and fails above 1024, from `npm test` and both packaging scripts -- CI and `vsce package` never checked this, which is how six releases went green and unpublished. Also corrects the 4.3.10 entry: the migration keeps the extension's own color rules, but scopes it never colored now take the theme's colors, which changes how @rules, rule concepts, "=" and .dict files look. Measured by rendering real files before and after. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every release since 4.3.4 failed at "Publish to the VS Code
Marketplace": "The provided icon image exceeds the maximum allowed
dimensions of 1024 by 1024 pixels." resources/NLPppLogo.png was
2066 x 2066. 4.3.5 and 4.3.6 hit it with vsce 3.9.2, so it is the
Marketplace's limit, not the vsce 4 bump. GitHub releases 4.3.5-4.3.10
exist; the Marketplace still serves 4.3.4.
The icon is resized to 1024 x 1024 (Lanczos, RGBA kept), and
scripts/check-icon.js reads the PNG header of package.json's icon and
fails above 1024, from
npm testand both packaging scripts -- CI andvsce packagenever checked this, which is how six releases wentgreen and unpublished.
Also corrects the 4.3.10 entry: the migration keeps the extension's
own color rules, but scopes it never colored now take the theme's
colors, which changes how @rules, rule concepts, "=" and .dict files
look. Measured by rendering real files before and after.
Verified:
npm run vsce-packagewith vsce 4 builds the .vsix with the 1024 icon; check-icon fails on the old icon and passes on the new; fullnpm testpasses.🤖 Generated with Claude Code