Repository navigation
Standard TextMate scope names; migrate workspace color rules (4.3.10) - #1233
Merged
Merged
Conversation
Bumps grammars/ to VisualText/nlpplus-tmbundle#3, which renames every invented scope to its TextMate-convention equivalent (keyword.constants -> constant.language, keyword.attribute -> entity.other.attribute-name, literal.* -> meta.literal.*, string.double -> string.quoted.double, the dictionary's comment/keyword/function borrowings, kbb concept levels, copied suffixes). Tokens are unchanged; only names differ -- checked over 16.3M tokens in 3,372 real files. colorizeAnalyzer() has been copying textMateRules keyed to the old names into every analyzer workspace. src/language/scopeMigration.ts maps each old name to every new name it used to cover (comment.line.dict was the dict headword and the .kb/.kbb/.tree comment) and rewrites those rules once, so existing colors are preserved exactly. The shipped templates were regenerated through the same function. Dry run over the 16 analyzer workspaces on this machine: all parse, all migrate. langTest checks the map against the grammars themselves: no old name survives unless it maps to itself, every new name exists. Closes VisualText#107. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps grammars/ to VisualText/nlpplus-tmbundle#3, which renames every
invented scope to its TextMate-convention equivalent (keyword.constants
-> constant.language, keyword.attribute -> entity.other.attribute-name,
literal.* -> meta.literal.*, string.double -> string.quoted.double, the
dictionary's comment/keyword/function borrowings, kbb concept levels,
copied suffixes). Tokens are unchanged; only names differ -- checked
over 16.3M tokens in 3,372 real files.
colorizeAnalyzer() has been copying textMateRules keyed to the old
names into every analyzer workspace. src/language/scopeMigration.ts
maps each old name to every new name it used to cover (comment.line.dict
was the dict headword and the .kb/.kbb/.tree comment) and rewrites
those rules once, so existing colors are preserved exactly. The shipped
templates were regenerated through the same function. Dry run over the
16 analyzer workspaces on this machine: all parse, all migrate.
langTest checks the map against the grammars themselves: no old name
survives unless it maps to itself, every new name exists.
Closes #107.
Merge order
🤖 Generated with Claude Code