Repository navigation
nlp --help grouped, with exit codes; a missing input exits 1; -OUT makes its folder (4.2.51) - #811
Merged
Merged
Conversation
…kes its folder (4.2.51) --help listed every switch in one flat list and got two wrong: -OUT is not an output directory but the folder for the run's logs and trees, in place of <input>_log, and the second plain argument is that folder, not an "outfile". It now groups the switches (running, debugging, limits and zone mode, compiled analyzers), says -WORK is the engine folder, and adds NLP_REC_LIMIT and the exit status. Two behaviors it would otherwise have had to describe: - A missing input file printed "Couldn't create parse instance", left a stray <file>_log folder and exited 0, which #484 meant to stop. It now says "[Error: no such input file: ...]" and exits 1. - -OUT naming a folder that did not exist was ignored without a word, and everything went to <input>_log. The folder is now made; if it cannot be, the run says so and exits 1. CI (Linux, Windows): the #484 step also checks a missing input file (exit 1, no stray folder) and -OUT to a new folder. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--help
The old
--helpwas one flat list, and two entries were wrong:-OUTis not an output directory. It is the folder for the run's logs and trees, in place of<input>_log.The new one:
-WORKis the engine folder;NLP_REC_LIMIT(the limit is N plus N/50 per node, with N 1000 by default; 0 lifts it) and the exit status.Two fixes it would otherwise have had to describe
<file>_logfolder, and exited 0, which test-nlp.exe segfaults due to missing analyzers #484 was meant to stop. It now says[Error: no such input file: ...]and exits 1.-OUTnaming a folder that did not exist was ignored without a word, and everything went to<input>_log. The folder is now made. If it can't be, the run says so and exits 1.The Python and Node bindings use the
analyze()overload that takes the text directly, so neither change touches them.Tests
-OUTto a new folder.--help, a normal run, a folder run, a missing input, and-OUTto a new folder.Version 4.2.51.
🤖 Generated with Claude Code