Skip to content

zone and endzone lines take no pass number (4.2.48) - #806

Merged
ddehilster merged 1 commit into
VisualText:masterfrom
ddehilster:fix/zone-pass-numbers
Oct 26, 2026
Merged

ddehilster merged 1 commit into
VisualText:masterfrom
ddehilster:fix/zone-pass-numbers

Conversation

@ddehilster

Copy link
Copy Markdown
Member

Problem

4.2.47 counted the zone and endzone lines of analyzer.seq as passes. The rest of the tooling doesn't:

  • in the engine, a folder line is not a pass at all;
  • the VS Code sequence view numbers only lines that have a pass file, plus tokenizers.

So in an analyzer using zone mode, every pass after a zone line was numbered one higher in the engine than in the sequence view, and two higher after endzone. With -DEV, clicking a pass opened the wrong ana###.tree. Analysis output was unaffected.

Change

runPass() returns without numbering when it meets a zone or endzone line, the same as a folder line. That covers every path:

  • the normal loop;
  • an inactive /zone line;
  • the no-zones fallback;
  • a stray endzone.

The explicit increments in execute() and executeZones() are removed.

Fixture pass 4.2.47 4.2.48 = sequence view
tokenize, lines 1, 2 1, 2
words, report (per zone) 4, 5 3, 4
summary (after endzone) 7 5

Tests

  • The zone-mode CI step now expects z00N-ana003.tree for the words pass.
  • All Windows fixture steps pass locally.

This also ships the bundled analyzers with parse-en-us v1.1.4 (the pos50 loop fix, #805). Version 4.2.48.

🤖 Generated with Claude Code

4.2.47 numbered the zone and endzone lines of analyzer.seq as passes.
A folder line is not a pass in the engine, and the VS Code sequence view
numbers only lines with a pass file (and tokenizers), so after a zone
line every engine pass number was one higher than the view's, two after
endzone: with -DEV, clicking a pass opened the wrong ana###.tree.

runPass() now skips zone and endzone lines without numbering them, like
a folder line, on every path: the normal loop, an inactive /zone line,
the no-zones fallback and a stray endzone. The explicit increments in
execute() and executeZones() are gone.

CI: the zone-mode step expects z00N-ana003.tree for the words pass,
which is pass 3 in the sequence view; it was ana004.

Also brings the bundled analyzers, with parse-en-us v1.1.4 (the pos50
loop fix), into a release (VisualText#805).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@ddehilster
ddehilster merged commit a20bff4 into VisualText:master Oct 26, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant