Repository navigation
zone and endzone lines take no pass number (4.2.48) - #806
Merged
Merged
Conversation
4.2.47 numbered the zone and endzone lines of analyzer.seq as passes. A folder line is not a pass in the engine, and the VS Code sequence view numbers only lines with a pass file (and tokenizers), so after a zone line every engine pass number was one higher than the view's, two after endzone: with -DEV, clicking a pass opened the wrong ana###.tree. runPass() now skips zone and endzone lines without numbering them, like a folder line, on every path: the normal loop, an inactive /zone line, the no-zones fallback and a stray endzone. The explicit increments in execute() and executeZones() are gone. CI: the zone-mode step expects z00N-ana003.tree for the words pass, which is pass 3 in the sequence view; it was ana004. Also brings the bundled analyzers, with parse-en-us v1.1.4 (the pos50 loop fix), into a release (VisualText#805). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
4.2.47 counted the
zoneandendzonelines ofanalyzer.seqas passes. The rest of the tooling doesn't:folderline is not a pass at all;So in an analyzer using zone mode, every pass after a
zoneline was numbered one higher in the engine than in the sequence view, and two higher afterendzone. With-DEV, clicking a pass opened the wrongana###.tree. Analysis output was unaffected.Change
runPass()returns without numbering when it meets azoneorendzoneline, the same as afolderline. That covers every path:/zoneline;endzone.The explicit increments in
execute()andexecuteZones()are removed.Tests
z00N-ana003.treefor thewordspass.This also ships the bundled analyzers with parse-en-us v1.1.4 (the pos50 loop fix, #805). Version 4.2.48.
🤖 Generated with Claude Code