Repository navigation
Remove the corporate analyzer from tests, debug configs and the help copy - #793
Merged
Merged
Conversation
…copy The corporate analyzer is gone from VisualText/analyzers (#43). - test-nlp no longer runs it (parse-en-us, a missing analyzer and the two-engine check remain); test/README.md says what it runs. - .vscode/launch.json loses its four Corp File/Dir configurations. - visualtext/Help/helps (the HTML help copy zipped by build-visualfiles): the corporate tutorial, the Quick Tour built on it and their TOC entries are removed; pages that cited it point to the NLP++ Textbook or say "an early sample analyzer", as in VisualText/visualtext-files#246. Closes #104, closes #105. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of removing the corporate analyzer everywhere: VisualText/analyzers#43 removes the analyzer, and VisualText/visualtext-files#246 removes its help. Closes #104 and #105, since both asked to update an analyzer that's now gone.
test-nlpno longer runscorporate. It still runs parse-en-us, checks that a missing analyzer fails cleanly, and runs the two-engine check from Closing one engine no longer breaks another in the same process (#791) (4.2.35) #792.test/README.mdnow says what it runs and drops the "taiparse / corporate / noop" list..vscode/launch.json: removed the four "Corp File/Dir (win/linux)" configurations; 10 remain.visualtext/Help/helps(the HTML help copy thatbuild-visualfiles.ymlzips), mirroring visualtext-files#246:HowToBuild/Corporate,HowToBuild/Tour15,Sample_Analyzers/Corporate_Analyzer.htmandIntroduction/VisualText_Quick_Tour.htm;Help.hhc: the Quick Tour and Corporate Analyzer entries are gone, and Sample Analyzers opens Database1;Help.chmis left as is.No engine code changes, so no version bump.
Tests:
test-nlpbuilds and passes locally, andlaunch.jsonstill parses.The engine's
analyzerssubmodule still points at an analyzers commit that includescorporate/. That clears up when the submodule is next bumped after analyzers#43 merges.🤖 Generated with Claude Code