Repository navigation
Remove the last relative include path (#39) - #781
Merged
Merged
Conversation
include/Api/lite/inline.h included "../prim/unicu.h"; every build and the compile-libs package have include/Api as an include root, so it is now "prim/unicu.h", like the other files that include it. No relative include paths remain. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #39.
include/Api/lite/inline.hincluded"../prim/unicu.h". That was the only relative include left inlite,cs,src,nlpandinclude. Every engine build, and the compile-libs package used by compiled analyzers, hasinclude/Apias an include root. So it's now"prim/unicu.h", the same aslite/fn.cpp,lite/str.handlite/tok.cpp. No behaviour changes, so there's no version bump.The rest of #39 should not be done, I think. The issue also suggests moving headers next to their
.cppfiles and removing the include paths from CMake. Butinclude/Apiis the engine's public header tree. It ships in nlpengine-compile-libs, and generated analyzer code and the Python package are built against those include roots. Flattening it would break them.Testing: the engine builds locally. CI covers Linux, macOS, the Python-package-style builds, and the Windows step that compiles an analyzer against the packaged headers.
🤖 Generated with Claude Code