Finalize process session ownership - #28
Draft
VisruthSK wants to merge 23 commits into
Draft
Conversation
… the repetitions support
Remove rand_core dependency (use rand::SeedableRng everywhere). Share drain_interrupt in platform/mod.rs; macOS gets process_group(0), Linux reuses the shared helper. Windows: use CompareStringOrdinal for case-insensitive env matching (imported in mod.rs, removed from raw.rs); pass application as &[u16] to spawn_process. Simplify LifecycleCommands::new to take working_directory and envs directly; replace run_in_both with fail-fast run_startup_both and best-effort run_teardown_both; deduplicate run_in to delegate to run_at. Extract MeasurementContext struct to module level; remove generic W from measure_all. Fix run_unmeasured to report cleanup errors when wait returns Err. Add candidate_startup_does_not_run_when_baseline_startup_fails test. Co-Authored-By: Letta Code <noreply@letta.com>
…utput Extract shared helpers (project, run, failure, repository, git, constants) into tests/common/mod.rs. Move lifecycle tests to tests/lifecycle.rs and output/reporting tests to tests/output.rs. Co-Authored-By: Letta Code <noreply@letta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation