fix: Prevent memory leaks causing OOM crashes in deployment - #137
fix: Prevent memory leaks causing OOM crashes in deployment#137VisionExpo wants to merge 2 commits into
Conversation
- Wraps `Image.open()` calls in context managers in `preprocessing.py` and `streamlit_app.py` to ensure file descriptors and memory are freed promptly, as PIL evaluates lazily. - Replaces unbounded `InMemoryCache()` fallback initialization in `cache.py` with `InMemoryCache(max_size=1000)` to ensure caching limits are properly enforced when Redis is unavailable. Co-authored-by: VisionExpo <84554295+VisionExpo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
codeant-ai
Bot
added
the
size:XS
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
| with Image.open(uploaded_file) as img: | ||
| image = img.copy() |
There was a problem hiding this comment.
Suggestion: A corrupted or MIME-spoofed upload raises PIL.UnidentifiedImageError during preview, terminating the Streamlit interaction before inference can report an error. [possible bug]
Assessment: 🟠 Major · 🔁 Occurrence: Sometimes
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** apps/api/streamlit_app.py
**Line:** 42:43
**Comment:**
*Possible Bug: A corrupted or MIME-spoofed upload raises `PIL.UnidentifiedImageError` during preview, terminating the Streamlit interaction before inference can report an error.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix| ) | ||
| self.redis = None | ||
| self.fallback_cache = InMemoryCache() | ||
| self.fallback_cache = InMemoryCache(max_size=1000) |
There was a problem hiding this comment.
Suggestion: When Redis becomes unavailable after startup, fallback_cache does not exist, so failed reads return None and failed writes are discarded instead of using bounded fallback storage. [cache]
Assessment: 🟠 Major · 🔁 Occurrence: Sometimes
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** src/solar_fault_detector/utils/cache.py
**Line:** 105:105
**Comment:**
*Cache: When Redis becomes unavailable after startup, `fallback_cache` does not exist, so failed reads return `None` and failed writes are discarded instead of using bounded fallback storage.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix- Renamed `y_true_list` and `y_pred_list` to `y_true` and `y_pred` in the `Evaluator` class's `evaluate` and `confusion_matrix` methods. - Ensures the append target variable names correspond accurately to their initializations, preventing `UnboundLocalError`s at runtime and failing CI checks (`F821`, `F841`). - Saved concatenated results to `y_true_arr` and `y_pred_arr` to ensure explicit `del` of source lists does not erase inputs necessary for metric computations. Co-authored-by: VisionExpo <84554295+VisionExpo@users.noreply.github.com>
1 participant
User description
Addresses severe memory leaking issues that were causing crashes post-deployment (such as on Render). Fixed unclosed PIL Image file handles and unbounded cache fallbacks.
PR created automatically by Jules for task 7730384688279776149 started by @VisionExpo
CodeAnt-AI Description
Prevent memory growth and deployment crashes during image processing
What Changed
Impact
✅ Fewer out-of-memory deployment crashes✅ Lower memory use during repeated image uploads✅ Bounded cache growth when Redis is unavailable💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.