Fix OOM crashes caused by PIL Image file handle memory leaks - #133
Fix OOM crashes caused by PIL Image file handle memory leaks#133VisionExpo wants to merge 1 commit into
Conversation
- Used `with Image.open(...) as img` context manager in `src/solar_fault_detector/data/preprocessing.py` and `apps/api/streamlit_app.py` to prevent unclosed file handles leading to memory leaks and OOM crashes in production environments like Render. - Updated `streamlit_app.py` to load and copy image memory appropriately within the context manager so Streamlit can successfully render it. - Fixed a hallucinated `NameError` variable initialization bug in `src/solar_fault_detector/training/evaluator.py`. Co-authored-by: VisionExpo <84554295+VisionExpo@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
codeant-ai
Bot
added
the
size:S
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
| with Image.open(uploaded_file) as img: | ||
| img.load() | ||
| image = img.copy() |
There was a problem hiding this comment.
Suggestion: Malformed or truncated uploads pass the MIME check but make Image.open or img.load raise, terminating the Streamlit script before the existing API error handling runs. [possible bug]
Assessment: 🟠 Major · 🔁 Occurrence: Sometimes
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** apps/api/streamlit_app.py
**Line:** 42:44
**Comment:**
*Possible Bug: Malformed or truncated uploads pass the MIME check but make `Image.open` or `img.load` raise, terminating the Streamlit script before the existing API error handling runs.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix| y_true = np.concatenate(eval_y_true_list) | ||
| y_pred = np.concatenate(eval_y_pred_list) |
There was a problem hiding this comment.
Suggestion: An empty or already-consumed dataset leaves these lists empty, so np.concatenate raises ValueError instead of returning evaluation results. [possible bug]
Assessment: 🟠 Major · 🔁 Occurrence: Rarely
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** src/solar_fault_detector/training/evaluator.py
**Line:** 40:41
**Comment:**
*Possible Bug: An empty or already-consumed dataset leaves these lists empty, so `np.concatenate` raises `ValueError` instead of returning evaluation results.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix1 participant
User description
This PR fixes an Out-Of-Memory (OOM) error that causes the application to crash over time. The issue was due to unclosed
PIL.Imagefile handles leaking memory and file descriptors. By wrappingImage.open()calls in awithcontext manager in both the Streamlit app and the preprocessing pipeline, file resources are now safely released. Also includes a minor variable initialization fix in the evaluator.PR created automatically by Jules for task 8249923188306363804 started by @VisionExpo
CodeAnt-AI Description
Prevent image-processing memory leaks and evaluation failures
What Changed
Impact
✅ Fewer long-running application crashes✅ Lower memory and file-descriptor usage during image processing✅ Working evaluation metrics and confusion matrices💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.