Pixel coords - #7
Open
JaredMohansingh wants to merge 7 commits into
Open
Conversation
…mitting entries in coords file when tooltip blocked
sarika93
requested changes
Jun 30, 2022
sarika93
left a comment
sarika93
left a comment
Member
There was a problem hiding this comment.
Partial review. Still need to test this.
…eights + modified camera controller script for better variable names/comments + removed hardcoding for camera intrinsics
sarika93
reviewed
Aug 11, 2022
|
|
||
| private bool ToolTipVisible() { | ||
| _fileLength = new System.IO.FileInfo("MaskedImages/MaskedImage" + _imageNumber + ".jpg").Length; | ||
| if ( _fileLength > 250628 ) { |
Member
There was a problem hiding this comment.
How will this work if you have two cameras with different image sizes (highly probable)?
Member
There was a problem hiding this comment.
As discussed, we'll only be using one camera. Add a TODO to update this to be more robust to deal with multiple cameras instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Camera script updated to include the calculations that :