Image masking - #5
Open
JaredMohansingh wants to merge 6 commits into
Open
Conversation
added 4 commits
June 17, 2022 19:59
… tick box in inspector, shaders added on materials for replacement ID
sarika93
requested changes
Jul 1, 2022
…e formatting + shader in script found via resources.load method instead of in inspector + sharpie file moved to models folder + images folders checked first for presence and created if not already existing
sarika93
requested changes
Jul 18, 2022
sarika93
left a comment
sarika93
left a comment
Member
There was a problem hiding this comment.
Since I can't add comments to binary files:
-
You have a Prefabs folder and Models folder, both containing the marker fbx. Please remove the Models folder.
-
When you removed your replacement shader from the robot and market, you didn't add back the standard shader. These objects are now textureless. Please update all of these to use the standard shader.
-
The market cover is still on the "Default" layer.
-
The camera culling mask is set to "Everything"
-
There is no new layer for rendering the marker cap, in general (I believe this is a change to physics settings).
… scene and images + code formatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merged the camera ,mask camera and shader replacement into one script , controlled by the tick box in inspector .