fix: post-merge corrections (viewer --version + .env.example docs) - #29
Merged
Conversation
- viewer: use AttachConsole(-1) so --version output reaches the terminal (WinExe subsystem has no console by default) - .env.example: keep 192.168.x.x placeholder (not a real IP) - .env.example: preserve ALLOWED_SENDERS clarification comment from S28
This was referenced Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up fixes for PRs #26 and #27 that were merged with two issues.
Changes
viewer/App.xaml.cs (fix for #26)
--versionflag used bareConsole.WriteLinein aWinExeapp — output was silently discardedAttachConsole(-1)(ATTACH_PARENT_PROCESS) before writing,FreeConsole()after*.env.example (fix for #27)
BROKER_HOST=192.168.x.xto192.168.1.10— a real-looking IP as placeholder is confusing192.168.x.xALLOWED_SENDERSmulti-line clarification comment added in S28 (the PR had replaced it with a shorter version)Closes
Closes #27