3d to svg upload download#6
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe 3D-to-SVG studio tool's UI is restructured into distinct pane sections (Model, SVG) with head buttons, updated CSS module classes/ids, and accessible drop-error/live-region status messaging replacing the previous status element, with corresponding wiring updates in the studio script. ChangesStudio Layout, Styling, and Status Messaging
Estimated code review effort: 2 (Simple) | ~15 minutes Sequence Diagram(s)sequenceDiagram
participant User
participant StudioUI as studio.ts
participant Worker as SVG Worker
participant DOM as DOM Elements
User->>StudioUI: Drop/upload model file
StudioUI->>DOM: Clear dropErrorEl, set liveEl "Loading model..."
alt Model load fails
StudioUI->>DOM: Write error to dropErrorEl, update liveEl
else Model load succeeds
StudioUI->>DOM: Mount model, clear liveEl
StudioUI->>Worker: Request SVG generation
alt Generation fails
Worker-->>StudioUI: Error message
StudioUI->>DOM: Render error in preview, stop snippetSpinnerEl, update liveEl
else Generation succeeds
Worker-->>StudioUI: SVG result
StudioUI->>DOM: Update snippetFrameEl, hide snippetSpinnerEl
end
end
Estimated code review effort: 2 (Simple) | ~15 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/pages/tools/_3d-to-svg/studio.css.ts (1)
197-227: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win
visuallyHiddenduplicates the project's existing.sr-onlyutility with a legacy CSS property.
src/styles/global.css.tsalready defines a canonical hidden-content pattern (.sr-only) usingclipPath: 'inset(50%)'. The newvisuallyHiddenstyle reimplements the same technique with the deprecatedclip: rect(0, 0, 0, 0)property and slightly different metrics (margin: '-1px'vs. no margin offset). Consider reusing the shared utility instead of introducing a second hidden-content pattern.♻️ Reuse the existing sr-only pattern
-// Screen-reader-only live region for transient announcements (e.g. loading), so -// they're conveyed without the visible layout shift a real status line causes. -export const visuallyHidden = style({ - position: 'absolute', - width: '1px', - height: '1px', - padding: 0, - margin: '-1px', - overflow: 'hidden', - clip: 'rect(0, 0, 0, 0)', - whiteSpace: 'nowrap', - border: 0 -}); +// Screen-reader-only live region for transient announcements (e.g. loading), so +// they're conveyed without the visible layout shift a real status line causes. +// Mirrors the shared `.sr-only` pattern in global.css.ts. +export const visuallyHidden = style({ + position: 'absolute', + width: '1px', + height: '1px', + padding: 0, + margin: 0, + overflow: 'hidden', + clipPath: 'inset(50%)', + whiteSpace: 'nowrap', + border: 0 +});🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/pages/tools/_3d-to-svg/studio.css.ts` around lines 197 - 227, The `visuallyHidden` style duplicates the existing hidden-content utility and should be replaced with the shared `.sr-only` pattern used in `src/styles/global.css.ts`. Update the `visuallyHidden` export in `studio.css.ts` to reuse that canonical accessibility helper (or mirror its exact `clipPath: 'inset(50%)'`-based approach and spacing), instead of keeping a separate `clip: rect(...)` implementation with different metrics.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/pages/tools/_3d-to-svg/studio.css.ts`:
- Around line 197-227: The `visuallyHidden` style duplicates the existing
hidden-content utility and should be replaced with the shared `.sr-only` pattern
used in `src/styles/global.css.ts`. Update the `visuallyHidden` export in
`studio.css.ts` to reuse that canonical accessibility helper (or mirror its
exact `clipPath: 'inset(50%)'`-based approach and spacing), instead of keeping a
separate `clip: rect(...)` implementation with different metrics.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: fa21cb6d-9fc8-4c35-9af3-0c1a8a998601
📒 Files selected for processing (3)
src/pages/tools/3d-to-svg.astrosrc/pages/tools/_3d-to-svg/studio.css.tssrc/pages/tools/_3d-to-svg/studio.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Bug Fixes