e2e: fix vlagent path collision in upgrade tests#2305
Open
AndrewChubatiuk wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
upgrade tests may run multiple collectors in parallel, that mount same host path, which lead to vlagent crashes
Summary by cubic
Fixes VLAgent upgrade e2e test crashes caused by HostPath collisions when multiple collectors run in parallel. Each test now uses a version-scoped tmp data path and volume to prevent mount conflicts.
vlagentK8sCollectorto enable the k8s collector and set a uniqueTmpDataPathandHostPathper version (e.g.,/var/lib/vlagent-data-<version>), with matchingVolume/VolumeMount(tmp-data).withVersionand updatedcrVersionPair.crto a factoryfunc(string) client.Object, so objects are created with the test’s version and unique paths.vlagentk8s collector configs withvlagentK8sCollectoracross versionsv0.68.0–v0.71.0.Written for commit 230cfe4. Summary will update on new commits.