fix: handle config-reloader secret watch tombstones#2303
Merged
AndrewChubatiuk merged 2 commits intoJun 17, 2026
Merged
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
AndrewChubatiuk
approved these changes
Jun 17, 2026
Contributor
|
@immanuwell thanks for contribution! |
AndrewChubatiuk
added a commit
that referenced
this pull request
Jun 18, 2026
* fix: handle config-reloader secret watch tombstones Signed-off-by: immanuwell <pchpr.00@list.ru> * added changelog --------- Signed-off-by: immanuwell <pchpr.00@list.ru> Co-authored-by: Andrii Chubatiuk <andrew.chubatiuk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes a small crash in
config-reloader.when the secret informer misses a delete event and catches it on relist,
client-gocan sendcache.DeletedFinalStateUnknowntoDeleteFunc. current code doesobj.(*corev1.Secret)and panics, so the reloader falls over.fix is pretty small:
*corev1.Secretpath the samerepro:
cmd/config-reloaderclient-godeliverscache.DeletedFinalStateUnknownDeleteFunctype asserts to*corev1.Secretand crasheschecks:
go test ./cmd/config-reloader/...make testSummary by cubic
Fix a crash in
config-reloaderwhen the secret watcher receives tombstone events. We now unwrapcache.DeletedFinalStateUnknowninstead of asserting directly to*corev1.Secret.secretFromEventto handle*corev1.Secretand tombstones (value and pointer) fromclient-go.secretFromEventand log unexpected types.docs/CHANGELOG.mdto note the fix.Written for commit afa7bed. Summary will update on new commits.