Support multiple cases for VMAlertmanagerConfig and scrape configs#2233
Open
AndrewChubatiuk wants to merge 1 commit into
Open
Support multiple cases for VMAlertmanagerConfig and scrape configs#2233AndrewChubatiuk wants to merge 1 commit into
AndrewChubatiuk wants to merge 1 commit into
Conversation
AndrewChubatiuk
changed the title
AndrewChubatiuk
force-pushed
the
support-multiple-cases
branch
from
93e3461 to
ee74e84
Compare
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
8 issues found across 42 files
Tip: instead of fixing issues one by one fix them all with cubic
Re-trigger cubic
AndrewChubatiuk
force-pushed
the
support-multiple-cases
branch
4 times, most recently
from
bdbd13d to
8007250
Compare
Contributor
Author
|
@cubic-ai-dev |
Contributor
@AndrewChubatiuk I have started the AI code review. It will take a few minutes to complete. |
Contributor
There was a problem hiding this comment.
2 issues found across 35 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
AndrewChubatiuk
force-pushed
the
support-multiple-cases
branch
7 times, most recently
from
ae83fb0 to
04bc75c
Compare
AndrewChubatiuk
force-pushed
the
support-multiple-cases
branch
2 times, most recently
from
afbff0c to
45cca9d
Compare
AndrewChubatiuk
force-pushed
the
support-multiple-cases
branch
from
45cca9d to
7dc2589
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1146
Summary by cubic
Adds case-insensitive support for both snake_case and camelCase in scrape CRDs and
VMAlertmanagerConfig, with strict spec validation and clearer errors. Preserves unknown fields inVMAlertmanagerConfig.specand removes underscore-only aliases across the API and controller.New Features
case:ignoretags on scrape params andjson.MatchCaseInsensitiveNames(true)+json.RejectUnknownMembers(true)during spec unmarshalling; errors now say “unknown object member name”.VMAlertmanagerConfig.spec(x-kubernetes-preserve-unknown-fields: true,+kubebuilder:pruning:PreserveUnknownFields).host_aliases,UnderScoreSourceLabels,UnderScoreTargetLabel); CRD schemas, controller logic, docs, and tests updated. API docs show both accepted aliases.Dependencies
github.com/go-json-experiment/json.Written for commit 7dc2589. Summary will update on new commits.