Repository navigation
one-dispatch-publishes-to-both-channels: npm is published from the same dispatch as the Marketplace - #873
Merged
VeryComplexAndLongName merged 1 commit intoOct 10, 2026
Conversation
…me dispatch as the Marketplace publish.yml replaces publish-marketplace.yml: one workflow_dispatch that takes vscode_version, cli_version and a typed confirmation, and publishes each channel only when its version is named. npm is authenticated by Trusted Publishing (no token), from main only, for the version packages/cli states and that is not yet on the registry. check-publish-workflow guards both channels. Records ADR-0048. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
VeryComplexAndLongName
deleted the
one-dispatch-publishes-to-npm-and-marketplace
branch
October 10, 2026 14:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
.github/workflows/publish.ymlreplacespublish-marketplace.yml: oneworkflow_dispatchwithvscode_version,cli_versionandconfirm; an empty version skips its channel; both publishing jobs need theconfirmjob.environment: npm,id-token: write, no token), only frommain, only for the versionpackages/cli/package.jsonstates and that is not yet on the registry. The pinned npm builds;npm@11.5.1is installed for the publish step alone.scripts/check-publish-workflow.mjsand its tests guard both channels.one-dispatch-publishes-to-both-channels, README and changeset README corrected.Before the first dispatch (owner's, tasks 4.5 and 4.6)
publish.ymland thenpmenvironment.npmenvironment exists in the repository settings.No package behaviour changes, so no changeset. Nothing here publishes anything.
🤖 Generated with Claude Code