Add the option to pass partial in data to updateSuccess - #74
Open
d3dc wants to merge 1 commit into
Open
Conversation
…er merge using ramda's `mergeDeepRight` Add tests to 'success.test.ts' and 'reducersFor.test.ts' for both list and map
Contributor
|
hi @d3dc thanks for working on this. Following the discussion in #34 it seems that people have different ideas on how this should behave. Would you be willing to modify your PR so the config takes functions for the update. e.g. something like a function that takes the prev item, the new item and returns the merged item. In that way we can support anything that people have in mind. The default function would be the current way of doing things. Also, please keep the previous whitespace formatting, changing the indentation makes it harder to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will cause the store merge to patch an existing record using ramda's
mergeDeepRightThis addresses #34.
Add tests to 'success.test.ts' and 'reducersFor.test.ts' for both list and map
(I think I may have been the first to autoformat according to the .editorconfig too...)