Repository navigation
Let the release job survive being re-run - #14
Merged
Merged
Conversation
Creating a GitHub release that already exists is an error, so the re-run that RELEASING.md recommends as the way out of a half-finished release always went red on its last step. It did on 0.5.0: the packages went up on the re-run and the job still reported failure, which reads like the release did not happen. The step now attaches the packages to the release that is already there. RELEASING.md records what 0.5.0 actually did, because the symptom was confusing and the next person deserves better than rediscovering it. Every step reported success, the release was created with the four packages attached, and nuget.org had nothing at that version by any route — version index, package URL, gallery page, search — while its own status page reported publishing as operational. Re-running pushed them. What to read next time is the push step itself, which says whether a package went up or was skipped as already there. PipelineEntrants.cs is only line endings. An edit of mine left \r\r\n on fifty of its lines and it went in that way; the content is byte-identical with whitespace ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a GitHub release that already exists is an error, so the re-run that RELEASING.md recommends as the way out of a half-finished release always went red on its last step. It did on 0.5.0: the packages went up on the re-run and the job still reported failure, which reads like the release did not happen. The step now attaches the packages to the release that is already there.
RELEASING.md records what 0.5.0 actually did, because the symptom was confusing and the next person deserves better than rediscovering it. Every step reported success, the release was created with the four packages attached, and nuget.org had nothing at that version by any route — version index, package URL, gallery page, search — while its own status page reported publishing as operational. Re-running pushed them. What to read next time is the push step itself, which says whether a package went up or was skipped as already there.
PipelineEntrants.cs is only line endings. An edit of mine left \r\r\n on fifty of its lines and it went in that way; the content is byte-identical with whitespace ignored.