Repository navigation
Paint uncolored tiling patterns in the color selected with the pattern - #578
Merged
Merged
Conversation
The cell of a PaintType 2 tiling pattern was recorded on a fresh graphics state, so its shapes were painted black instead of in the color given to scn/SCN together with the pattern. Seed the recording's fill and stroke color with that color. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scn/SCNwith the pattern.record_content_streamtakes an optionalcell_colorthat seeds the recording's fill and stroke color;compute_shaderpasses the current fill (or stroke) color for uncolored patterns. Colored patterns and soft masks are unchanged.Test plan
cargo test -p pdf-canvascargo clippy -p pdf-canvas --all-targetspath_5_pattern.pdf: the UnColorPattern shapes show green / purple / red / teal suits, as PDFium does🤖 Generated with Claude Code