Repository navigation
Add optional_rect and required_rect dictionary readers - #567
Merged
Merged
Conversation
Read four-number rectangle entries by key and use them for /CropBox, /RD, /BBox and /MediaBox instead of repeating optional_array_of::<f32, 4>. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Conformance readsDocuments that Safe-PDF reads differently from the base commit, compared with PDFium. A read pdf.js corpus1008 documents compared with Regressions
840 documents of the PDFium corpus read as on Details are in the job summaries of the workflow run. Rerun a case locally with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dictionary::optional_rect(key, objects)andDictionary::required_rect(key, objects)to read a four-number array entry as aRect, keeping the original coordinate order./CropBox(document and page) and/RD(annotation subtypes), and buildoptional_bbox,required_bboxandoptional_media_boxon top of them. Behavior is unchanged./Domainin function shadings stays anoptional_array_of::<f32, 4>read: it is[xmin xmax ymin ymax], not a rectangle.Testing
cargo clippy --all --workspace,cargo fmt --checkcargo test -p pdf-object-reader -p pdf-document -p pdf-annotation-core🤖 Generated with Claude Code