Add player location to voice HUD for Condition Zero - #298
Merged
Conversation
a1batross
requested changes
Mar 23, 2026
Vladislav4KZ
force-pushed
the
czero-voicechat-locations
branch
3 times, most recently
from
March 24, 2026 07:51
0c6711d to
2d17c0e
Compare
Vladislav4KZ
force-pushed
the
czero-voicechat-locations
branch
from
March 24, 2026 09:46
2d17c0e to
a8e1f97
Compare
Contributor
Author
|
Replaced |
Vladislav4KZ
marked this pull request as draft
March 24, 2026 11:26
Vladislav4KZ
force-pushed
the
czero-voicechat-locations
branch
from
March 24, 2026 11:47
a8e1f97 to
cb00c0a
Compare
Vladislav4KZ
marked this pull request as ready for review
March 24, 2026 11:49
a1batross
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced a buggy
sizeof(newLocation)calculation inCVoiceLabel::SetLocationwith correct string length calculation usingstrlen() + 1and copying viastrcpy.This prevents location names from being truncated to 4-8 characters.
Adjusted
GetContentSizeby replacing(m_playerName) + 8with(m_buf)so the background box spans the full string (name + location), and removed the extra 8 pixels to reduce empty space on the right.The official localization files use
%ls(wchar_t).Since regular strings (
char*) are passed, the text would disappear due to a type mismatch.As a result, code was added to replace
%lswith%s, ensuring player and location names display correctly.