Anonumous mouse/issue76 - #77
Open
AnonumousMouse wants to merge 2 commits into
Open
Conversation
First attempt at laying out fixes Valkyr-JS#76
…ults - also added logic to check for minimum scene count before others and added conditions to avoid continuing queries when unescessary.
AnonumousMouse
commented
Apr 22, 2025
Author
There was a problem hiding this comment.
I assume the other changes are fine but my edits to this file likely has some issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR for resolving the referenced issue (#76).
I hacked together some basic foundation with my very limited proficiency of react/plugin dev. No clue if it works at all and I won't be able to sit down to try and set up a test environment up anytime soon. But if any of this can be of use to you, feel free to amend my attempts. I suspect the way I tried to conditionally cancel queries and change loading screens is highly problematic.