Skip to content

feat(e2k): kanalizerに移行#1694

Merged
Hiroshiba merged 13 commits into
VOICEVOX:project-e2kfrom
sevenc-nanashi:e2k/feat/kanalizer
May 23, 2025
Merged

feat(e2k): kanalizerに移行#1694
Hiroshiba merged 13 commits into
VOICEVOX:project-e2kfrom
sevenc-nanashi:e2k/feat/kanalizer

Conversation

@sevenc-nanashi

Copy link
Copy Markdown
Member

内容

e2kをkanalizerにします。

関連 Issue

スクリーンショット・動画など

(なし)

その他

(なし)

@sevenc-nanashi
sevenc-nanashi requested a review from a team as a code owner May 20, 2025 09:04
@sevenc-nanashi
sevenc-nanashi requested review from Hiroshiba and removed request for a team May 20, 2025 09:04
@Hiroshiba

Copy link
Copy Markdown
Member

enable_e2kフラグに関してこのコメントから引用まで 🙏

他には全体的にenable_e2kってフラグを引きずり回してるんですが、これは一旦そのまま置いといていただければと・・・!
そもそも実験的機能じゃなくするんだったら削除する場所もあるのと、まだ名称をどうするか決めてないのと、e2kという名前に一意性があって後で変更しやすいので、一旦このままのがありがたいかな~と!!

Comment thread voicevox_engine/tts_pipeline/katakana_english.py Outdated
@Hiroshiba
Hiroshiba requested review from Copilot, takana-v and tarepan May 20, 2025 09:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR transitions the text-to-speech pipeline from using e2k to using kanalizer for converting unknown English words to katakana. Key changes include replacing e2k with kanalizer in katakana_english.py, updating license information, and removing e2k dependency references from run.spec, requirements, and pyproject.toml.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
voicevox_engine/tts_pipeline/katakana_english.py Replace e2k conversion with kanalizer and update error fallback logic
tools/generate_licenses.py Remove e2k license URL
run.spec Remove e2k data files collection
requirements-dev.txt Remove e2k dependency and add kanalizer dependency
requirements-build.txt Remove e2k dependency and add kanalizer dependency
pyproject.toml Remove e2k dependency and add kanalizer dependency
Comments suppressed due to low confidence (1)

voicevox_engine/tts_pipeline/katakana_english.py:68

  • [nitpick] The variable name 'add_alphabet_yomi' could be more descriptive, for example, 'use_fallback_conversion', to better indicate that it triggers the fallback conversion path.
add_alphabet_yomi = False

@takana-v takana-v left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APIの引数等にe2kenable_e2k)が含まれていますが、最終的には変更してしまっていいかなと思っています。
(上のコメントを見逃していたのでコメント修正済)

Comment thread tools/generate_licenses.py

@tarepan tarepan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍️
新ライブラリ導入により高い精度の読み推定が期待されます。ユーザーの声が楽しみですね!

🤔
CI が落ちています。
内容は「Voivoボ'イボ と読んでいたものが ヴォ'イヴォ と読まれるように変わった」というものです。
e2k 導入に伴いアルファベットの読みが変換したものであり、特段問題ないと考えます。
これを解決するため、snapshot 更新が必要です。CONTRINBUTING.md に手順があります。

@sevenc-nanashi
sevenc-nanashi requested a review from tarepan May 20, 2025 11:35
Comment thread tools/generate_licenses.py Outdated
Comment thread tools/generate_licenses.py Outdated
Comment thread uv.lock
Comment thread tools/generate_licenses.py Outdated
@Hiroshiba
Hiroshiba requested a review from takana-v May 22, 2025 04:35
Comment thread uv.lock
Comment thread tools/generate_licenses.py Outdated
@sevenc-nanashi
sevenc-nanashi requested a review from tarepan May 23, 2025 06:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the text conversion and license management from the e2k dependency to kanalizer. Key changes include:

  • Replacing e2k import and usage with kanalizer in text conversion.
  • Updating test snapshots and expected output strings to reflect the new conversion.
  • Adjusting license generation scripts and dependencies to remove e2k and add kanalizer.

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
voicevox_engine/tts_pipeline/katakana_english.py Updated dependency and conversion logic to use kanalizer.
tools/generate_licenses.py Removed e2k license info and patched license info for kanalizer.
test/unit/tts_pipeline/test_katakana_english.py Updated expected output for the new conversion.
test/e2e/single_api/tts_pipeline/snapshots/test_audio_query/test_post_audio_query_enable_e2k_200.json Updated snapshot data for conversion changes.
test/e2e/single_api/tts_pipeline/snapshots/test_accent_phrases/test_post_accent_phrases_enable_e2k_200.json Updated snapshot data for conversion changes.
run.spec Removed data collection for e2k.
requirements-dev.txt, requirements-build.txt, pyproject.toml Removed e2k dependency and added kanalizer.

@tarepan tarepan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
_patch_licenses_manually() により自動差し替え(_update_licenses())と区別したのも良い実装だと感じます。
実利用が楽しみです!

@takana-v takana-v left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かい所をコメントしましたが、それ以外はLGTMです。

Comment thread tools/generate_licenses.py Outdated
Co-authored-by: takana-v <44311840+takana-v@users.noreply.github.com>

@Hiroshiba Hiroshiba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

楽しみですね!!!!!
マージ後ビルドしてみます!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants