Skip to content

chore: pyopenjtalk を最新版に更新(API変更対応)#1640

Merged
Hiroshiba merged 4 commits into
VOICEVOX:masterfrom
Hiroshiba:feature/pyopenjtalk-update-20250424
Apr 23, 2025
Merged

chore: pyopenjtalk を最新版に更新(API変更対応)#1640
Hiroshiba merged 4 commits into
VOICEVOX:masterfrom
Hiroshiba:feature/pyopenjtalk-update-20250424

Conversation

@Hiroshiba

@Hiroshiba Hiroshiba commented Apr 23, 2025

Copy link
Copy Markdown
Member

内容

  • pyopenjtalk を VOICEVOX/pyopenjtalk の main 最新コミット(74703b034dd90a1f199f49bb70bf3b66b1728a86)に更新
  • API変更(create_user_dict→mecab_dict_index, set_user_dict→update_global_jtalk_with_user_dict)に対応
  • 依存ファイル(pyproject.toml, requirements.txt, poetry.lock, requirements-dev.txt, requirements-build.txt)を全て再生成
  • 静的解析(mypy, ruff, typos)・pytest 全て通過

関連 Issue・PR

ref: VOICEVOX/pyopenjtalk#25
ref: VOICEVOX/pyopenjtalk#24

スクリーンショット・動画など

なし

その他

  • 破壊的API変更に伴い、ユーザー辞書生成・反映処理を全て新APIに置換
  • 既存テストも全て修正し、全通過を確認

@Hiroshiba
Hiroshiba requested a review from a team as a code owner April 23, 2025 16:54
@Hiroshiba Hiroshiba changed the title pyopenjtalk を最新版に更新(API変更対応) chore: pyopenjtalk を最新版に更新(API変更対応) Apr 23, 2025
Comment thread pyproject.toml Outdated
@Hiroshiba
Hiroshiba requested review from Copilot and tarepan April 23, 2025 16:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the pyopenjtalk dependency to the latest commit to accommodate breaking API changes and refreshes all related dependency files. Key changes include:

  • Replacing the deprecated pyopenjtalk methods (create_user_dict and set_user_dict) with the new API methods (mecab_dict_index and update_global_jtalk_with_user_dict) in the user dictionary manager.
  • Updating pyopenjtalk revision references in requirements-build.txt and pyproject.toml.
  • Removing the six dependency from requirements-build.txt.

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

File Description
voicevox_engine/user_dict/user_dict_manager.py Updated API calls to align with the new pyopenjtalk methods.
requirements-build.txt Changed the pyopenjtalk commit revision and removed the six dependency.
pyproject.toml Updated the pyopenjtalk commit revision to point to the new version.
Files not reviewed (1)
  • requirements-dev.txt: Language not supported

@Hiroshiba

Copy link
Copy Markdown
Member Author

pyopenjtalkの更新を行いました!!!

@sabonerune さんと @sevenc-nanashi さんのおかげです、ありがとうございます!!!!!!

@nanae772
多分 uv では

uv add git+https://github.com/VOICEVOX/pyopenjtalk@74703b034dd90a1f199f49bb70bf3b66b1728a86 --no-cache

みたいな感じで更新できると思います!! 🙏

@tarepan tarepan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hiroshiba
Hiroshiba enabled auto-merge April 23, 2025 18:56
@Hiroshiba
Hiroshiba added this pull request to the merge queue Apr 23, 2025
Merged via the queue into VOICEVOX:master with commit 38b3224 Apr 23, 2025
@Hiroshiba
Hiroshiba deleted the feature/pyopenjtalk-update-20250424 branch April 29, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants