chore: pyopenjtalk を最新版に更新(API変更対応)#1640
Merged
Hiroshiba merged 4 commits intoApr 23, 2025
Merged
Conversation
Hiroshiba
commented
Apr 23, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the pyopenjtalk dependency to the latest commit to accommodate breaking API changes and refreshes all related dependency files. Key changes include:
- Replacing the deprecated pyopenjtalk methods (create_user_dict and set_user_dict) with the new API methods (mecab_dict_index and update_global_jtalk_with_user_dict) in the user dictionary manager.
- Updating pyopenjtalk revision references in requirements-build.txt and pyproject.toml.
- Removing the six dependency from requirements-build.txt.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| voicevox_engine/user_dict/user_dict_manager.py | Updated API calls to align with the new pyopenjtalk methods. |
| requirements-build.txt | Changed the pyopenjtalk commit revision and removed the six dependency. |
| pyproject.toml | Updated the pyopenjtalk commit revision to point to the new version. |
Files not reviewed (1)
- requirements-dev.txt: Language not supported
Member
Author
|
pyopenjtalkの更新を行いました!!! @sabonerune さんと @sevenc-nanashi さんのおかげです、ありがとうございます!!!!!! @nanae772 みたいな感じで更新できると思います!! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
内容
関連 Issue・PR
ref: VOICEVOX/pyopenjtalk#25
ref: VOICEVOX/pyopenjtalk#24
スクリーンショット・動画など
なし
その他