Skip to content

Stop inherited backdrops from picking up lower replacements - #11

Merged
mauroerta merged 1 commit into
mainfrom
fix/backdrop-inherit-precedence
Sep 14, 2026
Merged

mauroerta merged 1 commit into
mainfrom
fix/backdrop-inherit-precedence

Conversation

@mauroerta

Copy link
Copy Markdown
Member

Summary

  • Fix shared backdrop resolution so an unset top overlay stops at the environment backdrop instead of adopting a lower overlay's replacement.
  • backdrop: false still skips downward; custom replacements and all-opt-out still behave as before.
  • Add a regression for upper inherit over lower custom, and include a patch changeset.

Test plan

  • pnpm --filter @vlkoss/cue test
  • Open lower with a custom backdrop, then upper with no backdrop override → environment backdrop
  • Upper backdrop: false over lower custom → custom
  • Upper unset over lower false with environment backdrop → environment
  • Upper custom → custom
  • Every open overlay backdrop: false → no backdrop

Made with Cursor

An unset overlay backdrop should resolve to the environment dim, not keep walking the stack for a custom one underneath.

Co-authored-by: Cursor <cursoragent@cursor.com>
@changeset-bot

changeset-bot Bot commented Sep 14, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9ea1be7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vlkoss/cue Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mauroerta
mauroerta merged commit 2393328 into main Sep 14, 2026
1 check passed
@mauroerta
mauroerta deleted the fix/backdrop-inherit-precedence branch September 14, 2026 22:42
@github-actions github-actions Bot mentioned this pull request Sep 14, 2026
mauroerta pushed a commit that referenced this pull request Sep 14, 2026
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @vlkoss/cue@1.1.1

### Patch Changes

- [#11](#11)
[`2393328`](2393328)
Thanks [@mauroerta](https://github.com/mauroerta)! - Stop inherited
backdrops from using a lower overlay's replacement. The top
participating overlay now resolves to the environment backdrop when it
does not set one.

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant