Repository navigation
audit-r11: correct env-knob pointer attribution (README honesty fix) - #196
Merged
Merged
Conversation
The round-10 pointer line claimed all nine PCB-generation overrides were 'documented in docs/agents/project-specs.md' -- only QSSC_PCB_PATH actually is. The pour/rail overrides (QSSC_ZONE_CLEARANCE_NM, QSSC_ZONE_MIN_WIDTH_NM, QSSC_RAIL_MICRO, QSSC_STITCH_STEP) live in hardware/HARDWARE_DESIGN.md, and the via/gap/debug overrides (QSSC_VIA_DIAM_NM, QSSC_VIA_DRILL_NM, QSSC_COPPER_GAP_NM, QSSC_ROUTE_DEBUG) had no doc at all (code comments only). Reworded to state they are read by tools/route_qssc_pcb.py and tools/router/* with the pour/rail ones described in HARDWARE_DESIGN.md -- no false single-file attribution. Round-11 also probed two remaining axes and found no defects: - frontend/dist is NOT committed (0 tracked files; CI builds it) -- no src-vs-dist drift surface. - BOM.csv MPNs vs DATASHEETS.md are consistent: the BTB connectors match exactly (main 61302011121 / head 61002021121), semiconductors match by base part (AD7616, LM358, MCP4921, USB4105 -- BOM carries the orderable package suffix), and the rest are generic passives/headers that need no pinout entry. Green: ruff, env-doc + readme gates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round-11 audit: one real defect — a documentation-attribution error I introduced in round 10 — plus two remaining axes probed clean.
The fix: false pointer attribution (my own R10 error)
The round-10 README pointer claimed all nine PCB-generation overrides were "documented in
docs/agents/project-specs.md" — but onlyQSSC_PCB_PATHactually is:QSSC_ZONE_CLEARANCE_NM,QSSC_ZONE_MIN_WIDTH_NM,QSSC_RAIL_MICRO,QSSC_STITCH_STEP) live inhardware/HARDWARE_DESIGN.mdQSSC_VIA_DIAM_NM,QSSC_VIA_DRILL_NM,QSSC_COPPER_GAP_NM,QSSC_ROUTE_DEBUG) had no doc at all (code comments only)Reworded to state accurately that they are read by
tools/route_qssc_pcb.pyandtools/router/*, with the pour/rail ones described inHARDWARE_DESIGN.md— no false single-file attribution.Two axes probed clean (no defects)
61302011121/ head61002021121); semiconductors match by base part (AD7616, LM358, MCP4921, USB4105 — BOM carries the orderable package suffix); the rest are generic passives/headers needing no pinout entry. This closes the last axis flagged in R10.Green
ruff · env-doc + readme gates (4 passed).