Repository navigation
Croagunk Swap Shop Menu Documentation - #336
Merged
Merged
Conversation
Most mission types have subtypes, though many are irrelevant for dungeon generation in particular.
Now called mission_template
They don't really belong in dungeon/enum.h, as they are used in both modes.
see previous commit
Finally, all non-zero fields are accounted for! We have TEXT STRINGS!
Documentation for the rescue.bin file
Added context and renamed certain mission enums
I don't know much about it, but functions are using certain fields of it.
...with appropriate signage
I have to wonder if these aliases will even be missed...
Oops!
:D :D :D
Whitespace whyyyyyy
Contributor
Author
|
Okay, so I think I've gone through and taken care of the feedback. There are a few things I may come back to in another PR, namely documenting the overlay11 functions I'm taking stabs in the dark at right now, but we should be good to go now. |
UsernameFodder
requested changes
Aug 24, 2025
| ENUM_16_BIT(script_routine_kind); | ||
| #pragma pack(pop) | ||
|
|
||
| enum swap_shop_shared_case { |
Owner
There was a problem hiding this comment.
I didn't mean to make you do extra research, sorry. I thought this was smaller/you already knew the cases. In the future if you don't know all the cases feel free to just say so and leave it as an int.
Contributor
Author
There was a problem hiding this comment.
Nah, I did have this information, it was just a matter of naming each case honestly. Probably better that it's done than not done.
Co-authored-by: UsernameFodder <93669634+UsernameFodder@users.noreply.github.com>
UsernameFodder
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should document everything in overlay_21 more thoroughly, and a handful of functions in overlay_11 as well.