Skip to content

fix: set seeking_owner status on approval when project has no owner - #191

Merged
hturnbull93 merged 2 commits into
mainfrom
fix/project-approval-seeking-owner-status
Jul 29, 2026
Merged

fix: set seeking_owner status on approval when project has no owner#191
hturnbull93 merged 2 commits into
mainfrom
fix/project-approval-seeking-owner-status

Conversation

@hturnbull93

Copy link
Copy Markdown
Collaborator

Summary

  • Approved projects with no owner now get seeking_owner status instead of in_progress
  • Removed dead needs_tasks branch — tasks are required at proposal time so openTaskCount is always > 0 at approval
  • isSeekingHelp defaults to true when no owner (seeking_owner implies seeking help); respects targetStatus === seeking_help when owner exists

Test plan

  • Approve a volunteer-proposed project (no owner) → status shows Seeking Owner
  • Approve a project where admin set themselves as owner → status shows In Progress
  • All 150 e2e tests pass

🤖 Generated with Claude Code

Projects approved without an assigned owner were incorrectly set to
in_progress or needs_tasks. Since tasks are now required at proposal
time, the needs_tasks branch was dead code; and without an owner the
correct status is seeking_owner, not in_progress.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@railway-app
railway-app Bot temporarily deployed to PauseAI Catalyse / catalyse-pr-191 July 29, 2026 16:09 Destroyed
…nals

Instead of using a targetStatus param overridden by the admin, approval
now reads isSeekingHelp and assigneeId already set by the proposer:
- no owner → seeking_owner
- owner + seeking help → seeking_help
- owner + not seeking help → in_progress

Removes targetStatus from ReviewProjectSchema and all call sites.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@railway-app
railway-app Bot temporarily deployed to PauseAI Catalyse / catalyse-pr-191 July 29, 2026 16:19 Destroyed
@hturnbull93
hturnbull93 merged commit 0f2e660 into main Jul 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant