refactor: consolidate match grades into single config - #190
Merged
Conversation
Replace magic strings and duplicated grade set with a typed `MATCH_GRADES` array that owns labels, thresholds, and notifiability in one place. Rename lib/project-match.ts → lib/project-match-notify.ts to reflect purpose. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HSjjc1dDRePv7f5YNVjs88
railway-app
Bot
temporarily deployed
to
PauseAI Catalyse / catalyse-pr-190
July 27, 2026 19:07
Destroyed
|
🚅 Deployed to the catalyse-pr-190 environment in PauseAI Catalyse
1 service not affected by this PR
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GradeConfiginterface andMATCH_GRADEStyped array inlib/matching.tsas single source of truth for grade labels, thresholds, and notifiabilitymatchGradeLabelnow derives fromMATCH_GRADESinstead of hardcoded if-chain; array is runtime-sorted descending sofind()always works correctlyproject-match.tsrenamed toproject-match-notify.tsto reflect its purposeNOTIFIABLE_GRADESin the notify file derived fromMATCH_GRADES— no more duplicated magic stringsTest plan
npm run check-allpasses🤖 Generated with Claude Code
https://claude.ai/code/session_01HSjjc1dDRePv7f5YNVjs88