fix: gate signup/edit actions behind volunteer approval - #185
Merged
Conversation
Unapproved applicants could self-claim tasks, edit projects, message volunteers, and submit local group suggestions — only project creation and expressInterest were gated. Adds approvedProcedure and applies it across the affected routes, blocks admins from assigning projects/tasks/starter-tasks to unapproved volunteers, and excludes unapproved volunteers from volunteers.list (which feeds both assign dropdowns and the public directory). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VQAA85HZaaMjk12sx5xjbZ
railway-app
Bot
temporarily deployed
to
PauseAI Catalyse / catalyse-pr-185
July 25, 2026 09:23
Destroyed
|
🚅 Deployed to the catalyse-pr-185 environment in PauseAI Catalyse
1 service not affected by this PR
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updateTask, editing a project, messaging volunteers, and submitting local group suggestions were only checking auth, notapprovalStatus.approvedProcedureinserver/procedures.tsand applied it toprojects.create/update/expressInterest/createTask/reorderTasks/updateTask/assignTask/deleteTask,messages.send,localGroupSuggestions.create.projects.assign,projects.assignTask,starterTasks.assign— the last had no check at all).volunteers.listnow excludes unapproved volunteers, which fixes both the assign dropdowns (previously listed unapproved volunteers who'd then fail on submit) and the public volunteer directory.Test plan
npm run check-all(typecheck, lint, format, full e2e suite — 142 passed / 6 skipped)e2e/tests/21-approval-gate.spec.tscovers: blocked propose/express-interest/self-claim-task/message/local-group-suggestion for unapproved volunteers, blocked admin-assign to unapproved volunteer (project/task/starter-task), and unapproved volunteers excluded fromvolunteers.list🤖 Generated with Claude Code
https://claude.ai/code/session_01VQAA85HZaaMjk12sx5xjbZ