fix: sidenav unexpected behavior#1177
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
📝 WalkthroughSummary by CodeRabbit
WalkthroughReplaces ChangesAnimation Library Migration
Sidebar Collapse Toggle and MobileNav Accessibility
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Biome (2.5.0)frontend/src/styles/globals.cssFile contains syntax errors that prevent linting: Line 4: Tailwind-specific syntax is disabled.; Line 86: Tailwind-specific syntax is disabled.; Line 134: Tailwind-specific syntax is disabled.; Line 138: Tailwind-specific syntax is disabled.; Line 212: Tailwind-specific syntax is disabled.; Line 215: Tailwind-specific syntax is disabled.; Line 218: Tailwind-specific syntax is disabled.; Line 221: Tailwind-specific syntax is disabled.; Line 225: Tailwind-specific syntax is disabled.; Line 228: Tailwind-specific syntax is disabled.; Line 231: Tailwind-specific syntax is disabled.; Line 234: Tailwind-specific syntax is disabled.; Line 238: Tailwind-specific syntax is disabled.; Line 242: Tailwind-specific syntax is disabled.; Line 246: Tailwind-specific syntax is disabled.; Line 250: Tailwind-specific syntax is disabled.; Line 254: Tailwind-specific syntax is disabled.; Line 258: Tailwind-specific syntax is disabled.; Line 262: Tailwind-specific syntax is disabled.; Line 266: Tailwind-spe ... [truncated 303 characters] ... tax is disabled.; Line 294: Tailwind-specific syntax is disabled.; Line 298: Tailwind-specific syntax is disabled.; Line 302: Tailwind-specific syntax is disabled.; Line 306: Tailwind-specific syntax is disabled.; Line 310: Tailwind-specific syntax is disabled.; Line 314: Tailwind-specific syntax is disabled.; Line 318: Tailwind-specific syntax is disabled.; Line 322: Tailwind-specific syntax is disabled.; Line 326: Tailwind-specific syntax is disabled.; Line 330: Tailwind-specific syntax is disabled.; Line 334: Tailwind-specific syntax is disabled.; Line 338: Tailwind-specific syntax is disabled.; Line 342: Tailwind-specific syntax is disabled.; Line 346: Tailwind-specific syntax is disabled.; Line 350: Tailwind-specific syntax is disabled.; Line 354: Tailwind-specific syntax is disabled. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Pre-Submission PR Checklist
Description of the change
Fixes the mobile side navigation sliding off to the right and disappearing when the user taps outside it on small screens. The issue was caused by shacn's sheet's animation utilities not being loaded.
Changes:
Replaced the dead tailwindcss-animate dependency with tw-animate-css
(the Tailwind v4 successor) and imported it in globals.css; removed
the hand-rolled right-only sheet-* keyframes. The Sheet's own
side-aware classes now drive the animation, so the left sheet slides
left and right-docked sheets slide right.
Added a visually-hidden SheetTitle to the mobile nav (resolves the
Radix DialogContent requires a DialogTitle screen-reader warning).
Removed the non-functional collapse chevron from the mobile sheet
header (it was a no-op on mobile, sitting next to the close X) via a
new showCollapseToggle prop on Sidebar; the desktop collapse toggle is
unchanged.
Related issues: https://app.asana.com/1/1201607307149189/project/1209460078641109/task/1215145641561038?focus=true
Screenshot(s)