Repository navigation
feat(banner): show what is new in 3.2, readable at 80 columns - #182
Merged
Merged
Conversation
The welcome panel's "Did you know?" block becomes "What's new in 3.2": one row per new feature, written as the keys that reach it, then the switch for inline hints. The link to wiki/whats-new.md (new, and in the site nav) sits under the logo. The left column is a fixed 43 columns, so the URL shows in full at any width. Every right-hand row now fits in the 32 cells the right column has on an 80-column terminal. The 3.1 rows, and two "Getting started" rows, were written for about 40 and were cut with an ellipsis there. Under LANG=C, the identity line printed a UTF-8 middle dot that header_width() cannot decode, so it stopped counting and the frame went out of line. In that locale it is now a dash. HELLISH_HEADER_REV goes to 4, so users who saw the 3.1 panel see this one. banner_update_test.py had the revision hard-coded as 3; it now reads it from incs/version.h. tests/banner_news_test.py renders the panel at 80 and 120 columns, in UTF-8 and in C. It checks four things: - every framed row is the terminal's width; - no news row is clipped; - the guide link shows in full; - the guide is in mkdocs.yml's nav and names every key the banner shows. On the 3.1.3 build it fails 7 checks, the LANG=C frame among them. Lengthening one row makes it fail at 80 columns only. Also: the autosuggestions entry on interactive.md's roadmap is now marked shipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The welcome panel's "Did you know?" block becomes What's new in 3.2: one row per new feature, written as the keys that reach it, then the switch for inline hints. The panel links to a new guide,
wiki/whats-new.md, at univers42.github.io/hellish/whats-new. The guide covers every feature with an example run on a 3.2 build.(80 columns, rendered from this branch)
…. The link sits under the logo, because the left column is a fixed 43 columns.LANG=Cframe. The identity line printed a UTF-8·thatheader_width()cannot decode in that locale, so the row came out too wide. It is a-there now.HELLISH_HEADER_REVgoes to 4.banner_update_test.pynow reads the revision fromincs/version.hinstead of hard-coding it as3.mkdocs build --strictpasses, and every in-page anchor resolves.interactive.md's autosuggestions roadmap entry is now marked shipped.Tests:
tests/banner_news_test.py(new, 27 checks) renders the panel at 80 and 120 columns in UTF-8 and C. It checks four things:It fails 7 checks on the 3.1.3 build. Lengthening one row makes it fail at 80 columns only.
banner_update_test.pypasses all 16 checks with a clean HOME. A personal~/.hellishrcprompt hides the update badge, both before and after this change.🤖 Generated with Claude Code