Repository navigation
fix(build): make re no longer stops on a file NFS keeps for a running shell - #178
Merged
Merged
Conversation
… shell On NFS (the 42 machines' sgoinfre) a deleted file that a process still has open stays behind as .nfsXXXX until that process exits, and removing it fails with "Device or resource busy". With any shell started from build/bin still running, fclean's final `rm -rf build` hit exactly that file, so `make re` stopped before compiling anything and left no binary. fclean now accepts a build tree reduced to such files: it says which one it kept and succeeds; the rebuild is unaffected, since the file has a name of its own. Anything else that cannot be removed is retried and fails the target as before. tests/fclean_nfs_test.py cuts the recipe out of the Makefile and runs it next to the repo: with only a held-open .nfs file fclean succeeds and names it; with an unwritable directory it still fails. Off NFS no .nfs file appears and the test reports SKIP. Verified on sgoinfre: `make re` exit 2 before, exit 0 after, with a shell from build/bin running.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On sgoinfre (NFS), a deleted file still open in a process stays as
build/bin/.nfsXXXXand cannot be removed. With any shell frombuild/binrunning,fclean'srm -rf buildfailed andmake restopped with no binary.fcleannow succeeds when only such files remain, and names them; anything else that cannot be removed still fails the target.tests/fclean_nfs_test.pyruns the recipe cut from the Makefile: only-.nfs→ succeeds; unwritable dir → fails; off NFS → SKIP.make reexit 2 before, exit 0 after, with a shell frombuild/binrunning.🤖 Generated with Claude Code