Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Two commits, three files.
ci(release): request protoc on macOS build targets— passes the newsystem-packages-brew: protobufinput to the reusable release workflow.chore(release): 2.1.1— version bump inCargo.tomlandCargo.lock.Why
The 2.1.0 release run failed. Both macOS targets died with:
LanceDB's
lance-encodingcompiles protobuf definitions at build time, soprotochas to exist on every target. The reusablerust-releaseworkflow gated its package-install step onrunner.os == 'Linux', so the macOS runners got no build dependencies at all. The gap stayed invisible until now because CI itself is Linux-only, and no UniverLab binary neededprotocbefore RAG brought LanceDB in.Fixed upstream in
UniverLab/workflows(5b8f40d), which adds asystem-packages-brewinput and a matching macOS install step. It is a separate input rather than a translation ofsystem-packagesbecause the names do not agree across package managers — apt calls itprotobuf-compiler, brew calls itprotobuf.Why 2.1.1 and not a re-release of 2.1.0. The failed run still created the
v2.1.0tag, andcreate-tagskips when the tag exists — which skips every downstream job, so re-running produces nothing. Rather than delete a published tag, 2.1.0 is left burned: it was tagged but never released, and no artifact or crate ever carried that number.v2.1.0remains as an orphan tag onfd2da6e.Related issue
n/a — follow-up to #41.
Checklist
Notes
Cargo.lockis regenerated alongsideCargo.tomland verified withcargo metadata --locked. Every CI and release job runs with--locked, so a stale lock fails them all before anything compiles.Merging this triggers the release workflow — its trigger is a pull request closed against
maintouchingCargo.toml, which the bump does.v2.1.1does not exist yet, socreate-tagwill create it and all four targets will build.Two manual steps follow the merge: the
Awaiting Manual Approvalgate before the crates.io publish, and the fact that this is the first publish under the nameharness-canopy— the crate does not exist on crates.io today.