Skip to content

fix(graphs): describe canopy-builder's one commit per spec #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JheisonMB merged 1 commit into from
Nov 4, 2026
Merged

fix(graphs): describe canopy-builder's one commit per spec #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/graphs/patterns/deterministic-commit.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,10 @@ the graph should publish the branch.

In `adversarial-developer` the documenter leaves its docs uncommitted, so
`Commit` lands the code and the docs together under the one subject.
`canopy-builder` commits twice the same way: `Commit spec` lands the
spec's own message after the completeness review, and `Commit auditor
fixes` lands `fix(<scope>): audit fixes for <name>` after the auditor's
repairs, and both push the branch when they succeed.
`canopy-builder` commits once per spec the same way: `Commit spec` lands
the spec's own message after the auditor's repairs pass the gates again,
and pushes the branch when it succeeds. Its documenter commits the docs
separately.

A second check can prove the commit landed — that HEAD moved since the
spec started — but neither loop needs one: the gates and the review
Expand Down
4 changes: 2 additions & 2 deletions apps/graphs/src/patterns-data.generated.ts
View file
Open in desktop

Large diffs are not rendered by default.

8 changes: 3 additions & 5 deletions apps/graphs/test/fixtures/graphs/adversarial-developer/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,10 @@ resilience node that can schedule its own wake-up.

Differences that matter when you move from here to `canopy-builder`:

- **One commit, at the end.** The documenter leaves its docs uncommitted
- **One commit, docs included.** The documenter leaves its docs uncommitted
and `Commit` lands the spec's work and its docs together, under the
spec's own message. `canopy-builder` commits the code first, reviews the
commit, and commits the audit fixes separately.
- **The auditor reads the working tree.** Here the change is
uncommitted when it audits; in `canopy-builder` it reads `HEAD`.
spec's own message. `canopy-builder` also commits once per spec, after the
auditor, but its documenter commits the docs separately.
- **No lock.** Nothing stops another process committing while the loop
runs, so do not run two of these against the same branch.
- **A designer failure ends the spec.** There is no resilience node to
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "canopy-web",
"version": "0.1.0",
"version": "0.1.1",
"description": "UniverLab graphs catalogue: JSON Schemas and validator for shareable Canopy graph and node documents",
"type": "module",
"license": "Apache-2.0",
Expand Down
Loading