test(territories): fix card-overlays FK flake by draining audit writes#205
Merged
Conversation
The card-overlays RLS integration test's afterAll deleted audit logs and then dropped the test congregations, but `audit()` is fire-and-forget via `unscopedDb`. An in-flight write could land after the deleteMany and break the congregation FK, causing intermittent FK failures in CI. Expose `flushPendingAuditWrites()` from the audit module and await it in the test's cleanup so all pending writes settle before the audit-log deleteMany runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
card-overlays.integration.test.tscleanup can intermittently fail with an FK violation onCongregation↔AuditLogbecauseaudit()is fire-and-forget viaunscopedDb— a stray write can land after the test'sauditLog.deleteManyand before thecongregation.deleteMany, leaving a referenced row.flushPendingAuditWrites()toaudit.server.tswhich tracks in-flightaudit()promises and lets callers await them. The test awaits it just before the cleanup deletes.audit()still doesn't block its callers; the helper is for tests that need to assert a clean slate.Test plan
pnpm test:unit(1146 tests passing, including 3 new tests coveringflushPendingAuditWrites)pnpm test:typecheckpnpm test:lintpnpm test:integration -- card-overlays.integration.test.ts— 5 consecutive clean runs locally