feat(sdk-core): add abstract (chain 2741) v3 support - #696
Open
gomesalexandre wants to merge 1 commit into
Open
Conversation
Abstract (ZK-stack L2, chainId 2741) has Uniswap V3 deployed per the gov RFC "Deploy Uniswap v3 on Abstract". Adds it to sdk-core: ChainId enum, average block time, SUPPORTED_CHAINS, and a CHAIN_TO_ADDRESSES_MAP entry. All addresses verified on-chain (chain 2741) before inclusion: - every V3 address has bytecode and cross-references correctly (swapRouter02 factory() and posManager factory() both point at the v3CoreFactory; factory feeAmountTickSpacing(500)=10; posManager name()="Uniswap V3 Positions NFT-V1") - the issue's proposed V2 factory/router were Ethereum-mainnet placeholders with NO code on Abstract, so V2 is omitted (like ZKSYNC and 10 other supported chains that ship no V2 factory) rather than shipping wrong addresses - block time measured ~0.4s/block over 3000 blocks Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #377
what
adds Abstract (ZK-stack L2, chainId 2741) to
sdk-corewith its Uniswap V3 deployment. Abstract has V3 live per the gov RFC "Deploy Uniswap v3 on Abstract", but it's absent fromsdk-core, so any SDK consumer can't resolve its contract addresses.how
chains.ts:ChainId.ABSTRACT = 2741, average block time (0.4),SUPPORTED_CHAINSaddresses.ts:ABSTRACT_ADDRESSES(V3 only) +CHAIN_TO_ADDRESSES_MAPentry (the derived V3 maps pick it up automatically)chains.test.ts+addresses.test.tsthe careful part: every address verified on-chain before inclusion
The issue proposed addresses marked "(to be verified)", and its V2 factory/router were Ethereum-mainnet placeholders (
0x5C69…aA6f/0x7a25…488D). Shipping wrong addresses in an SDK is how funds get lost, so I checked all of them against chain 2741 (https://api.mainnet.abs.xyz):0xA1160e73B63F322ae88cC2d8E700833e71D0b2a1feeAmountTickSpacing(500)= 10 ✅0x2cB10Ac97F2C3dAEDEaB7b72DbaEb681891f51B8factory()→ the v3CoreFactory ✅0xfA928D3ABc512383b8E5E77edd2d5678696084F9name()= "Uniswap V3 Positions NFT-V1",factory()→ v3CoreFactory ✅0x117Fc8DEf58147016f92bAE713533dDB828aBB7efactory()→ v3CoreFactory ✅0x9CA4dcb2505fbf536F6c54AA0a77C79f4fBC35C00x9c7d30F93812f143b6Efa673DB8448EfCB9f747EV2 is omitted on purpose: the proposed V2 addresses have no bytecode on Abstract, and V2 was never in the RFC. 11 supported chains already ship no V2 factory (including
ZKSYNC, the same ZK-stack family), so omitting is standard, not a gap.Block time measured ~0.43s/block over 3000 blocks →
0.4.receipts