Add Akita Share Token (■AKITA) on Base - #92
Conversation
… BNB Smart Chain (BSC) tokens (trustwallet#35486)
* chore: update Machines Cash dapp logo * chore: update MACHINES token logo on Base * chore: update MACHINES token metadata on Base * chore: update MACHINES links/tags metadata * chore: update MACHINES links to allowed names and productivity tag * chore: add source_code link and retrigger metadata checks * chore: use allowed tag and coinmarketcap URL format * chore: retrigger token validator on latest metadata * Rename 'twitter' to 'x' in info.json --------- Co-authored-by: twhino <231496232+twhino@users.noreply.github.com>
[sc-118816]
Co-authored-by: tw-jt <231277539+tw-jt@users.noreply.github.com>
* Create info.json * Create logo.png * Update logo.png
Delete logo.png files for Ethereum token 0x57e299eE8F1C5A92A9Ed54F934ACC7FF5F159699 and Tron asset 1001411. Removes two binary logo assets from the repository as part of asset cleanup.
[sc-120452]
Update pump.fun DApp logo [sc-120452]
* Mark FAKE FAKE KAT as FAKE * Update info.json --------- Co-authored-by: tw-jt <231277539+tw-jt@users.noreply.github.com>
Co-authored-by: TWmLorejo <214106588+TWmLorejo@users.noreply.github.com>
* Add four meme AI logo [sc-120984] * Enlarge logo
* Mark FAKE FAKE YELOOW as FAKE * Update info.json
* Mark FAKE YELLOW as FAKE * Update token symbol in info.json --------- Co-authored-by: curiouschonk <146854853+curiouschonk@users.noreply.github.com>
Co-authored-by: TWmLorejo <214106588+TWmLorejo@users.noreply.github.com>
Add Aave asset metadata and logo files for Arbitrum, Avalanche (C-Chain) and xDai, and update existing AAVE entries across Ethereum, Fantom, Polygon, BSC (Smart Chain) and Solana. Changes standardize website/explorer fields, add research, tags and links (github, x, reddit, blog, facebook, whitepaper, coinmarketcap, coingecko), correct explorer IDs/casing, and replace several logo images. Purpose: unify and enrich AAVE token metadata across multiple chains for consistent display and discovery. [sc-122587]
* Update Asset Names High Priority [sc-149289] * Normalize token names across blockchains Simplify token names by removing network-specific prefixes/suffixes (e.g., "BNB pegged", "(PoS)", "Bridged ... (Sonic Labs)") and standardize names for well-known tokens like USDC, Tether, Chainlink, and others across Avalanche, Ethereum, Meter, Polygon, BSC, Solana, and Sonic.
[sc-149289] Update asset metadata and token lists to use current token and project display names across Ethereum, Arbitrum, Avalanche, Fantom, Optimism, BSC, Solana, and xDai. This aligns bridged and native entries with consistent branding such as Yearn, 1inch, Synthetix, CoW Protocol, SafePal, and Ondo market assets.
* Update token names across multiple chains [sc-149289] Standardize and simplify token display names across Ethereum, BSC, Polygon, Avalanche, Arbitrum, Optimism, Fantom, Base, Solana, Tron, TON, Binance, and Oasis chains. Changes include removing verbose suffixes (e.g. 'Token', 'Network', 'Binance-Peg', 'Portal'), renaming Ondo tokenized assets by dropping 'ETF' from names, and updating deprecated names (e.g. 'UST Token' → 'TerraClassicUSD', 'ZigCoin' → 'ZIGChain', 'CertiK Token' → 'Shentu'). * Add (Portal) suffix to bridged token names [sc-149289] Clarify that UST on Avalanche C-Chain, SLP and SPELL on Solana are Portal-bridged versions by appending "(Portal)" to their names.
* chore(kb): sdd-init scaffold Requested-by: Maksim Alov (+71356433702) Session: kbb-acadef63-assets-1784718319528 Feature-id: kbb-acadef63 Agent-role: kb-bootstrap * chore(kb): sdd-knowledge --full build Requested-by: Maksim Alov (+71356433702) Session: kbb-acadef63-assets-1784718319528 Feature-id: kbb-acadef63 Agent-role: kb-bootstrap * chore(kb): LLM deep-analysis enrichment + repo manifest Requested-by: Maksim Alov (+71356433702) Session: kbb-acadef63-assets-1784718319528 Feature-id: kbb-acadef63 Agent-role: kb-bootstrap * chore(kb): finalize knowledge base bootstrap Requested-by: Maksim Alov (+71356433702) Session: kbb-acadef63-assets-1784718319528 Feature-id: kbb-acadef63 Agent-role: kb-bootstrap * fix(ci): allow kb bootstrap files in root folder validation Requested-by: Conductor Bot (conductor-bot) Session: ci-mon-292456d0-ci-1784719035411 Feature-id: ci-mon-292456d0 Agent-role: ci-monitor --------- Co-authored-by: Maksim Alov <maksim.alov@trustwallet.com> Co-authored-by: Conductor Bot <conductor-bot@trustwallet.com> Co-authored-by: Ivan B <82358585+tw-covain@users.noreply.github.com>
PR trustwallet#37428 committed local agent/spec-kit scaffolding that does not belong in this repository. Removes: - `.claude/` — agent slash commands, skills and generated repo manifest - `.github/workflows/knowledge-sync.yml` — a docs-sync workflow that depends on infrastructure unavailable to this repository - `.specify/` — spec-kit scripts and templates - `.mcp.json` — MCP server registration Also drops the corresponding entries from the root-folder allowlist in `.github/assets.config.yaml` (`CLAUDE.md` and `knowledge/` stay — those files remain), trims `CLAUDE.md` down to the parts that apply to this repository, and removes three empty `knowledge/` placeholders that only existed to mirror the deleted spec-kit workflow, fixing every link that pointed at them. No asset files, validation logic or CI checks are affected. `make check` passes (48843 files, 0 errors). Co-authored-by: Max Alov <>
|
Updated |
ERC20 ShareOFT 0xcCC10Ec9282F66dd4e344DF52F5D670D10Fd4626 Co-authored-by: Cursor <cursoragent@cursor.com>
07129ae to
f796b1f
Compare
| run: | | ||
| SYNC_OPTIONS="--follow-symlinks --delete --exclude '*' --include 'dapps/*' --include 'blockchains/*'" | ||
| if [ "${{ github.event.inputs.use-size-only }}" == "true" ]; then | ||
| SYNC_OPTIONS="$SYNC_OPTIONS --size-only" | ||
| fi | ||
| eval "aws s3 sync . s3://$AWS_S3_BUCKET $SYNC_OPTIONS" |
There was a problem hiding this comment.
Semgrep identified a blocking 🔴 issue in your code:
User-controlled github.event.inputs.use-size-only is interpolated directly into a run: step and used in eval, allowing command injection via workflow dispatch input.
More details about this
The run: step passes ${{ github.event.inputs.use-size-only }} directly into a conditional that modifies SYNC_OPTIONS, which is then used in an eval statement. This creates a command injection vulnerability.
Exploit scenario:
- An attacker opens a workflow dispatch request (which triggers on
workflow_dispatchevents) and provides a malicious value for theuse-size-onlyinput parameter - The attacker sets
use-size-onlyto:true"; malicious_command; echo " - When the conditional evaluates
if [ "${{ github.event.inputs.use-size-only }}" == "true" ], it becomes:if [ "true"; malicious_command; echo "" == "true" ] - The shell parses this as three commands:
[ "true",malicious_command, andecho "" - The
malicious_commandexecutes with full access to the runner environment, includingAWS_S3_BUCKETsecret - The attacker can now read secrets, exfiltrate code, or modify the repository
The real danger is that SYNC_OPTIONS is later used in eval, which interprets shell metacharacters. Even if the attacker can't break out of the conditional, they could inject options into SYNC_OPTIONS that cause unintended behavior.
To resolve this comment:
✨ Commit fix suggestion
| run: | | |
| SYNC_OPTIONS="--follow-symlinks --delete --exclude '*' --include 'dapps/*' --include 'blockchains/*'" | |
| if [ "${{ github.event.inputs.use-size-only }}" == "true" ]; then | |
| SYNC_OPTIONS="$SYNC_OPTIONS --size-only" | |
| fi | |
| eval "aws s3 sync . s3://$AWS_S3_BUCKET $SYNC_OPTIONS" | |
| run: | | |
| SYNC_OPTIONS="--follow-symlinks --delete --exclude '*' --include 'dapps/*' --include 'blockchains/*'" | |
| if [ "$USE_SIZE_ONLY" = "true" ]; then | |
| SYNC_OPTIONS="$SYNC_OPTIONS --size-only" | |
| fi | |
| eval "aws s3 sync . s3://$AWS_S3_BUCKET $SYNC_OPTIONS" | |
| env: | |
| AWS_S3_BUCKET: ${{ secrets.AWS_S3_BUCKET }} | |
| USE_SIZE_ONLY: ${{ github.event.inputs.use-size-only }} |
View step-by-step instructions
- Move the untrusted workflow input out of the
run:script and into the stepenv:block, for example by addingUSE_SIZE_ONLY: ${{ github.event.inputs.use-size-only }}. - Replace the direct GitHub expression inside the shell script with the environment variable, changing the condition to
if [ "$USE_SIZE_ONLY" = "true" ]; then. - Keep the environment variable quoted everywhere you read it in the shell script, because
"$USE_SIZE_ONLY"prevents shell metacharacters in the input from being interpreted as code. - Leave
AWS_S3_BUCKETinenv:as it is, and keep shell variable references quoted where possible, for exampleaws s3 sync . "s3://$AWS_S3_BUCKET" .... - Remove GitHub
${{ ... }}interpolation from thisrun:block entirely so the script only reads shell variables provided throughenv:.
💬 Ignore this finding
Reply with Semgrep commands to ignore this finding.
/fp <comment>for false positive/ar <comment>for acceptable risk/other <comment>for all other reasons
Alternatively, triage in Semgrep AppSec Platform to ignore the finding created by run-shell-injection.
You can view more details about this finding in the Semgrep AppSec Platform.
|
Superseded: #92 targeted abandoned remine-1 ShareOFT Canonical remine-2 ■AKITA is Closing in favor of the clean multi-chain PR opened from |
|
Closing in favor of remine-2 multi-chain PR (see comment above). |
|
New PR: #94 |
Add Akita Share Token on Base
Token details:
0x44710150A469DE368Abc82F05e6217086Be84626Project:
Share token for the Akita creator vault on 4626.fun (Base).
Website: https://4626.fun
Explorer: https://basescan.org/token/0x44710150A469DE368Abc82F05e6217086Be84626
Metadata: https://4626.fun/tokens/akita-share-token.json
Logo (canonical): https://4626.fun/tokens/akita-share-token.png
Checklist:
Made with Cursor