Move zsync.c helpers - refactoring - #3427
Open
mannreis wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
@WardF CI needs to be retriggered (and I can't do it manually - likely with an empty commit). GitHub action was having issues when I pushed :) |
mannreis
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is another refactoring task inspired by #3068. It only moves code around.
The commits are self-explanatory the only question I have is with df54dbd.
What are the implications of adding to a "public" API (
include/ncjson.hin this case)? Should this be avoided and instead I could declare it internally inlibnczarr/?