Fix various problems with S3 related code - #3090
Merged
Merged
Conversation
re: PR Unidata#3068 Part of splitting PR 3068. General goal is to fix minor bugs and issues involving S3 code outside of libnczarr. 1. libsrc/s3io.c: - Fix handling of error output of NC_s3sdkinfo. - Implement delete arg to s3io_close 2. Add support for Zarr-Over-HTTP (ZOH) protocol, but leave disabled until given the go-ahead from Manuel Reis. 3. Change the ncs3sdk API to light of eventual addition of Zarr V3 support. 4. Modify s3cleanup.in to catch and remove some previously overlooked entries in the Unidata S3 test bucket. 5. Modify s3gc.in to catch and properly remove Unidata S3 test bucket entries with old UIDs. 6. Modify ds3util.c: - Support use of a non-standard port -- H/T Manuel Reis - Clean up some memory leaks - Add disabled ZOH support - Better doc on how URLs are interpreted. - Document how .aws/config and .aws/credentials files are parsed. 7. Repair bugs in the internal S3 reader/writer module. - Allow API functions to return an http code (see also nch5s3comms.h). - Fix some casting warnings. 8. Fixes to ncs3sdk_h5.c, the dispatch wrapper for the internal S3 reader/writer - Move httptonc to this file. - Make conform to API modifications - Refactor the key search code. - Rename getkeys to list and searchkeys to listall. 9. Fixes to nczarr_test/s3util.c - Reflect ds3util.c API changes: e.g search->listall. 10. Add s3util.c to v3_nczarr_directory 11. Extend unit_test/test_s3dk.c to reflect S3 API changes. 12. Extend unit_test/run_s3sdk.sh to add new tests involving S3 API changes.
WardF
approved these changes
Apr 14, 2025
mannreis
reviewed
Apr 15, 2025
| #include "netcdf.h" | ||
| #include "ncuri.h" | ||
| #include "ncutil.h" | ||
| #include "netcdf_vutils.h" |
Contributor
There was a problem hiding this comment.
This seems to cause by default builds config to fail! Since there's not such header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re: PR #3068
Part of splitting PR 3068.
General goal is to fix minor bugs and issues involving S3 code outside of libnczarr.